feat: add support for API 35 EdgeToEdge #2187
Conversation
update versions update version fix more tests fixes sdk bump fix gradle save the response Sign In working chore: upgrade Gradle, AGP and Kotlin chore: move namespace to build.gradle chore: upgrade Lint API add new lines at EOF for checkstyle ci: temporarily stop building proguard-test test: update robolectric and use Looper ignore test clean update ci remove comments Bad code fix? unused imports more more fix fixes fix more fixes
Lyokone
force-pushed
the
feat/edge-to-edge
branch
from
150bc9d to
2e17c04
Compare
|
|
||
| <!-- Override the base FirebaseUI theme for edge-to-edge support --> | ||
| <style name="FirebaseUI" parent="Theme.MaterialComponents.DayNight.DarkActionBar"> | ||
| <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item> |
There was a problem hiding this comment.
We shouldn't rely on windowOptOutEdgeToEdgeEnforcement as that's going away in Android 16: https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge
thatfiredev
changed the base branch from
version-9.0.0-dev
to
version-9.1.0-dev
| const val min = 21 | ||
| const val compile = 35 | ||
| const val target = 35 | ||
| const val min = 23 |
There was a problem hiding this comment.
Let's keep the original comment here
| const val min = 23 | |
| // Note that auth uses a different minSdk than this and | |
| // should be changed in auth/build.gradle.kts | |
| const val min = 21 |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="ResourceName"> | ||
|
|
||
| <!-- Override the base FirebaseUI theme for edge-to-edge support --> | ||
| <style name="FirebaseUI" parent="Theme.MaterialComponents.DayNight.DarkActionBar"> | ||
| </style> | ||
|
|
||
| </resources> |
There was a problem hiding this comment.
Now that we're not overriding anything we don't need this file anymore.
| super.onCreate(savedInstanceState); | ||
|
|
||
| // Enable edge-to-edge for all activities | ||
| WindowCompat.setDecorFitsSystemWindows(getWindow(), false); |
There was a problem hiding this comment.
Given that this is just calling a single method, I'd prefer that we call this method in every other Activity rather than creating this new BaseActivity that is extended by all of them.
When we migrate the sample app to Kotlin, let's try to get rid of all of these "Base..." classes.
|
We need some padding on the screen that is shown when the user is signed in:
|
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
./gradlew checkto ensure the Travis build passes.