Ssrc bugbash fix #1117
Open
Ssrc bugbash fix #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion failure)
Using getDouble on a string parameter value, returns the appropriate default static value but logs a warning which looks incorrect ("%s" in the warning message?).
In the server template builder flow using cached template, evaluation using custom signals is not working as intended.
rathovarun1032
requested review from
ashish-kothari,
dsjadaun-google and
lahirumaramba
There was a problem hiding this comment.
This file looks identical to Version.java. Any reason to add it separately?
|
|
||
| assertEquals("Default value", evaluatedConfig.getString("Custom")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we also add a test to verify that parsing of cached template works as expected (all conditions, parameters, parameter groups are correctly parsed)?
| ImmutableMap<String, Boolean> evaluatedCondition = | ||
| context != null && !cache.getServerConditions().isEmpty() | ||
| ? ImmutableMap.copyOf( | ||
| conditionEvaluator.evaluateConditions(cache.getServerConditions(), context)) |
There was a problem hiding this comment.
Can we directly return an ImmutableMap result here?
| ImmutableMap<String, Boolean> evaluatedCondition = ImmutableMap.copyOf( | ||
| conditionEvaluator.evaluateConditions(cache.getServerConditions(), context)); | ||
| ImmutableMap<String, Boolean> evaluatedCondition = | ||
| context != null && !cache.getServerConditions().isEmpty() |
There was a problem hiding this comment.
Move this inside conditionEvaluator.evaluateConditions()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves two bugs identified during the recent bug bash related to server template evaluation and parameter handling.
Corrected Custom Signal Evaluation with Cached Templates
A bug was preventing custom signals from being evaluated correctly when the server template was initialized from a cache. The root cause was an issue with template serialization/deserialization in ServerVersion and Condtion. The key percentOperator was being used instead of the correct percentConditionOperator. This has been fixed, ensuring that cached templates are parsed correctly and evaluations work as intended.
Fixed Malformed Logging Warning for getDouble()
When getDouble() was called on a parameter with a string value, it correctly returned the default static value but produced a malformed warning in the logs (e.g., "Unable to convert %s to double type."). The string formatting in the logger has been corrected to properly display the value that failed conversion.