Skip to content

Commit 0788d22

Browse files
author
Pijush Chakraborty
committed
Updating comments and vars for readability
1 parent a08b91b commit 0788d22

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

firebase_admin/remote_config.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,20 +587,20 @@ def _compare_semantic_versions(self, target_value, actual_value, predicate_fn) -
587587
return self._compare_versions(str(actual_value),
588588
str(target_value), predicate_fn)
589589

590-
def _compare_versions(self, version1, version2, predicate_fn) -> bool:
590+
def _compare_versions(self, sem_version_1, sem_version_2, predicate_fn) -> bool:
591591
"""Compares two semantic version strings.
592592
593593
Args:
594-
version1: The first semantic version string.
595-
version2: The second semantic version string.
594+
sem_version_1: The first semantic version string.
595+
sem_version_2: The second semantic version string.
596596
predicate_fn: A function that takes an integer and returns a boolean.
597597
598598
Returns:
599599
bool: The result of the predicate function.
600600
"""
601601
try:
602-
v1_parts = [int(part) for part in version1.split('.')]
603-
v2_parts = [int(part) for part in version2.split('.')]
602+
v1_parts = [int(part) for part in sem_version_1.split('.')]
603+
v2_parts = [int(part) for part in sem_version_2.split('.')]
604604
max_length = max(len(v1_parts), len(v2_parts))
605605
v1_parts.extend([0] * (max_length - len(v1_parts)))
606606
v2_parts.extend([0] * (max_length - len(v2_parts)))

tests/test_remote_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ def test_evaluate_custom_signal_semantic_version(self,
821821

822822

823823
class MockAdapter(testutils.MockAdapter):
824-
"""A Mock HTTP Adapter that Firebase Remote Config with ETag in header."""
824+
"""A Mock HTTP Adapter that provides Firebase Remote Config responses with ETag in header."""
825825

826826
ETAG = 'etag'
827827

0 commit comments

Comments
 (0)