Skip to content

Remove redundant testUtil sourceset from firebase-database #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove redundant testUtil sourceset from firebase-database #4710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb71e21
Remove redundant testUtil sourceset from firebase-database
jmwski Feb 22, 2023
9dde2b5
changelog
jmwski Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-database/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# 20.1.0
* [unchanged] Updated to accommodate the release of the updated
[database] Kotlin extensions library.
* [fixed] Remove redundant gradle sourceSet to clear spurious Android Studio unbound reference errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need a changelog here, as this isn't a user-facing change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no need of changelog entries for non-user visible changes.



## Kotlin
Expand Down
5 changes: 0 additions & 5 deletions firebase-database/firebase-database.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ android {
java {
srcDir 'src/testUtil/java'
}
}
test {
java {
srcDir 'src/testUtil/java'
}
resources {
srcDirs "src/test/resources"
}
Expand Down