Skip to content

dataconnect: demo: build.gradle.kts: update dependencies #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 13, 2025

Update the dependencies used in the Data Connect demo application's build file. The primary change involves adopting the recommended practice of using the Firebase Bill of Materials (BoM) to manage the version of the firebase-dataconnect library. Additionally, several other key library versions are updated to more recent releases.

Highlights

  • Dependency Management: Switched the firebase-dataconnect dependency in the demo app's build.gradle.kts to use the Firebase Bill of Materials (BoM) version 33.15.0 instead of specifying an explicit version for the individual library.
  • Dependency Updates: Updated several other dependencies in the demo app, including the Android Gradle Plugin (8.10.1), kotlinx-serialization-core (1.8.1), androidx.appcompat (1.7.1), and androidx.lifecycle:lifecycle-viewmodel-ktx (2.9.1).

This comment was marked as resolved.

This comment was marked as off-topic.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dconeybe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the dependencies used in the Data Connect demo application's build file. The primary change involves adopting the recommended practice of using the Firebase Bill of Materials (BoM) to manage the version of the firebase-dataconnect library. Additionally, several other key library versions are updated to more recent releases, ensuring the demo remains current with the ecosystem.

Highlights

  • Dependency Management: Switched the firebase-dataconnect dependency in the demo app's build.gradle.kts to use the Firebase Bill of Materials (BoM) version 33.15.0 instead of specifying an explicit version for the individual library.
  • Dependency Updates: Updated several other dependencies in the demo app, including the Android Gradle Plugin (8.10.1), kotlinx-serialization-core (1.8.1), androidx.appcompat (1.7.1), and androidx.lifecycle:lifecycle-viewmodel-ktx (2.9.1).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates several dependencies in the demo project's build.gradle.kts file and switches firebase-dataconnect to use the Firebase BoM. Several of the specified new version numbers appear unusually high or may not correspond to current public stable releases. These versions should be carefully verified.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Test Results

   66 files   -    958     66 suites   - 958   1m 16s ⏱️ - 33m 23s
  559 tests  -  5 238    558 ✅  -  5 216  1 💤  - 21  0 ❌  - 1 
1 118 runs   - 10 539  1 116 ✅  - 10 496  2 💤  - 42  0 ❌  - 1 

Results for commit 01694b4. ± Comparison against base commit f735209.

This pull request removes 5238 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor

@dconeybe dconeybe requested a review from Copilot June 13, 2025 15:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions in the Data Connect demo app’s build file to adopt the Firebase Bill of Materials (BoM) for managing the firebase-dataconnect library and to refresh several other libraries to their most recent releases.

  • Switched from an explicit version for firebase-dataconnect to using the Firebase BoM (version 33.15.0).
  • Updated key dependencies including the Android Gradle Plugin (8.10.1), kotlinx-serialization-core (1.8.1), appcompat (1.7.1), and lifecycle-viewmodel-ktx (2.9.1).

@dconeybe dconeybe requested a review from aashishpatil-g June 13, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants