Address review comments and add missing copyright notices.

Author: jonsimantov

analytics/CMakeLists.txt

@@ -105,7 +105,7 @@ set_property(TARGET firebase_analytics PROPERTY FOLDER "Firebase Cpp")
 target_link_libraries(firebase_analytics
     PUBLIC firebase_app)
 if(WIN32)
-  target_link_libraries(firebase_analytics PUBLIC Crypt32.lib)
+  target_link_libraries(firebase_analytics PRIVATE Crypt32.lib)
 endif()
 # Public headers all refer to each other relative to the src/include directory,
 # while private headers are relative to the entire C++ SDK directory.

analytics/generate_windows_stubs.py

@@ -77,8 +77,6 @@ def generate_function_pointers(dll_file_path, header_file_path, output_h_path, o
     current_dll_hex_hash = dll_hash.hex()
     if current_dll_hex_hash not in known_hex_hashes:
         known_hex_hashes.append(current_dll_hex_hash)
-        # Sort for consistency, although not strictly required by the prompt
-        # known_hex_hashes.sort() # Decided against sorting to maintain order of addition for now
 
     with open(hash_file_path, 'w') as f:
         for hex_hash in known_hex_hashes:

analytics/src/analytics_desktop.cc

@@ -39,13 +39,6 @@ namespace analytics {
 #define ANALYTICS_DLL_FILENAME L"analytics_win.dll"
 
 static HMODULE g_analytics_module = 0;
-// It's generally safer to use local std::string copies within Initialize
-// for app_id and package_name to ensure their lifetime if Initialize
-// could theoretically be called multiple times with different App objects,
-// or if AppOptions getters returned temporaries.
-// Given AppOptions structure, direct use of app.options().app_id() etc.
-// within the Initialize call *should* be safe as App outlives the call,
-// but local copies are more robust.
 #endif  // defined(_WIN32)
 
 // Future data for analytics.
@@ -57,8 +50,6 @@ static bool g_analytics_collection_enabled = true;
 // Initializes the Analytics desktop API.
 // This function must be called before any other Analytics methods.
 void Initialize(const App& app) {
-  // app parameter is now used to retrieve AppOptions.
-
   g_initialized = true;
   internal::RegisterTerminateOnDefaultAppDestroy();
   internal::FutureData::Create();

analytics/windows/include/public/analytics.h

@@ -1,3 +1,5 @@
+// Copyright 2025 Google LLC
+
 #ifndef ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_ANALYTICS_H_
 #define ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_ANALYTICS_H_
 

analytics/windows/include/public/c/analytics.h

@@ -1,3 +1,5 @@
+// Copyright 2025 Google LLC
+
 #ifndef ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_C_ANALYTICS_H_
 #define ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_C_ANALYTICS_H_
 

analytics/windows/include/public/event_names.h

@@ -1,3 +1,5 @@
+// Copyright 2025 Google LLC
+
 #ifndef ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_EVENT_NAMES_H_
 #define ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_EVENT_NAMES_H_
 

analytics/windows/include/public/parameter_names.h

@@ -1,3 +1,5 @@
+// Copyright 2025 Google LLC
+
 #ifndef ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_PARAMETER_NAMES_H_
 #define ANALYTICS_MOBILE_CONSOLE_MEASUREMENT_PUBLIC_PARAMETER_NAMES_H_