Skip to content

Remove the deprecated GMA C++ SDK #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
env:
CCACHE_DIR: ${{ github.workspace }}/ccache_dir
GITHUB_TOKEN: ${{ github.token }}
xcodeVersion: "14.1" # Only affects Mac runners, and only for prerequisites.
xcodeVersion: "16.2" # Only affects Mac runners, and only for prerequisites.

concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.head_ref || github.ref }}
Expand Down Expand Up @@ -50,13 +50,30 @@ jobs:
os: ${{ fromJson(needs.prepare_matrix.outputs.matrix_os) }}
architecture: ${{ fromJson(needs.prepare_matrix.outputs.matrix_architecture) }}
python_version: ${{ fromJson(needs.prepare_matrix.outputs.matrix_python_version) }}
exclude:
# Do not attempt to use arm64 on Windows or Linux.
- os: windows-latest
architecture: arm64
- os: ubuntu-22.04
architecture: arm64
# Do not attempt to use x64 on Mac.
- os: macos-14
architecture: x64
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
- name: Force Java 11
if: runner.os != 'macOS'
shell: bash
run: echo "JAVA_HOME=${JAVA_HOME_11_X64}" >> $GITHUB_ENV
- name: Force Java 11 (mac)
if: runner.os == 'macOS'
shell: bash
run: echo "JAVA_HOME=${JAVA_HOME_11_arm64}" >> $GITHUB_ENV
- name: Store git credentials for all git commands
# Forces all git commands to use authenticated https, to prevent throttling.
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
schedule:
- cron: "0 21 * * *" # 9pm UTC = 1pm PST / 2pm PDT, 12 hours after testapps run

permissions: write-all

env:
GITHUB_TOKEN: ${{ github.token }}
numDays: 7
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
pull_request:
types: [opened, reopened, synchronize, labeled, unlabeled]

permissions: write-all

env:
triggerLabelFull: "tests-requested: full"
triggerLabelQuick: "tests-requested: quick"
Expand Down Expand Up @@ -51,6 +53,9 @@ jobs:
# This check succeeds if Doxygen documentation generates without errors.
runs-on: ubuntu-22.04
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- uses: actions/checkout@v3
with:
submodules: false
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/checks_secure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
pull_request_target:
types: [synchronize]

permissions: write-all

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
Expand Down
36 changes: 24 additions & 12 deletions .github/workflows/cpp-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ env:
demumbleVer: "df938e45c2b0e064fb5323d88b692d03b451d271"
# Use SHA256 for hashing files.
hashCommand: "sha256sum"
# Xcode version 15.1 is the version we build the SDK with.
# Xcode version 16.2 is the version we build the SDK with.
# Our MacOS runners will use the version in /Applications/Xcode_${xcodeVersion}.app
xcodeVersion: "15.1"
xcodeVersion: "16.2"
# LLVM version with ARM MachO support has no version number yet.
llvmVer: "5f187f0afaad33013ba03454c4749d99b1362534"
GITHUB_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -79,17 +79,20 @@ jobs:
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
strategy:
matrix:
os: [ubuntu-22.04, macos-13]
os: [ubuntu-22.04, macos-14]
include:
- os: ubuntu-22.04
tools_platform: linux
# Binutils 2.35.1 released Sep 19, 2020
binutils_version: "2.35.1"
- os: macos-13
- os: macos-14
tools_platform: darwin
# Binutils 2.35.1 released Sep 19, 2020
binutils_version: "2.35.1"
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
Expand Down Expand Up @@ -185,9 +188,12 @@ jobs:

build_and_package_ios_tvos:
name: build-and-package-ios-tvos
runs-on: macos-13
runs-on: macos-14
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: Store git credentials for all git commands
# Forces all git commands to use authenticated https, to prevent throttling.
shell: bash
Expand Down Expand Up @@ -248,6 +254,9 @@ jobs:
strategy:
fail-fast: false
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: Force Java 11
shell: bash
run: echo "JAVA_HOME=${JAVA_HOME_11_X64}" >> $GITHUB_ENV
Expand Down Expand Up @@ -308,7 +317,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-22.04, macos-13]
os: [windows-latest, ubuntu-22.04, macos-14]
build_type: ["Release", "Debug"]
architecture: ["x64", "x86", "arm64"]
msvc_runtime: ["static", "dynamic"]
Expand All @@ -326,21 +335,21 @@ jobs:
vcpkg_triplet_suffix: "linux"
additional_build_flags: ""
sdk_platform: "linux"
- os: macos-13
- os: macos-14
vcpkg_triplet_suffix: "osx"
additional_build_flags: "--target_format libraries"
sdk_platform: "darwin"

exclude:
- os: windows-latest
linux_abi: "c++11"
- os: macos-13
- os: macos-14
architecture: "x86"
- os: macos-13
- os: macos-14
msvc_runtime: "dynamic"
- os: macos-13
- os: macos-14
linux_abi: "c++11"
- os: macos-13
- os: macos-14
build_type: "Debug"
- os: ubuntu-22.04
msvc_runtime: "dynamic"
Expand All @@ -352,6 +361,9 @@ jobs:
architecture: "arm64"

steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: Store git credentials for all git commands
# Forces all git commands to use authenticated https, to prevent throttling.
shell: bash
Expand Down Expand Up @@ -492,7 +504,7 @@ jobs:
suffix: '-x64-Debug-dynamic'
runs_on_platform: ubuntu-22.04
- sdk_platform: darwin
runs_on_platform: macos-13
runs_on_platform: macos-14
exclude:
- sdk_platform: windows
suffix: ''
Expand Down
22 changes: 19 additions & 3 deletions .github/workflows/desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@ jobs:
# msvc_runtime excludes
- os: ubuntu-22.04
msvc_runtime: "dynamic"
- os: macos-13
- os: macos-14
msvc_runtime: "dynamic"
# architecture excluees
- os: macos-13
- os: macos-14
architecture: "x86"
- os: macos-14
architecture: "x64"
# Xcode excludes -- allow only one on osx and linux
- os: ubuntu-22.04
xcode_version: "11.7"
Expand All @@ -95,6 +97,9 @@ jobs:
- xcode_version: "11.7"
architecture: "arm64"
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- name: Store git credentials for all git commands
# Forces all git commands to use authenticated https, to prevent throttling.
shell: bash
Expand Down Expand Up @@ -165,9 +170,17 @@ jobs:

- name: Setup python
uses: actions/setup-python@v4
if: startsWith(matrix.os, 'ubuntu')
with:
python-version: ${{ matrix.python_version }}
architecture: 'x64'
architecture: x64

- name: Setup python (Mac)
uses: actions/setup-python@v4
if: startsWith(matrix.os, 'macos')
with:
python-version: ${{ matrix.python_version }}
architecture: ${{ matrix.architecture }}

- name: Install Desktop SDK prerequisites
uses: nick-invision/retry@v2
Expand Down Expand Up @@ -296,6 +309,9 @@ jobs:
strategy:
fail-fast: false
steps:
- uses: lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- uses: actions/checkout@v3
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
Expand Down
Loading
Loading