Skip to content

Remove Dynamic Links and Invites #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jonsimantov
Copy link
Contributor

This commit removes the deprecated Dynamic Links SDK and all related Invites code from the Firebase C++ SDK.

Changes made:

  • Deleted the dynamic_links directory.
  • Deleted app/src/invites/ and app/invites_resources/.
  • Updated CMakeLists.txt files (root, app, release_build_files) to remove references to dynamic_links and invites.
  • Updated Gradle build files (Android/firebase_dependencies.gradle, release_build_files/Android/firebase_dependencies.gradle, settings.gradle) to remove dynamic_links and invites dependencies and resource references.
  • Updated build scripts (build_scripts/ios/build.sh, build_scripts/packaging.conf) to remove dynamic_links.
  • Updated GitHub Actions workflows (.github/workflows/cpp-packaging.yml, .github/workflows/integration_tests.yml) to remove dynamic_links.

Next steps involve removing test configurations and documentation related to Dynamic Links and Invites.

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

This commit removes the deprecated Dynamic Links SDK and all related Invites code from the Firebase C++ SDK.

Changes made:
- Deleted the `dynamic_links` directory.
- Deleted `app/src/invites/` and `app/invites_resources/`.
- Updated CMakeLists.txt files (root, app, release_build_files) to remove references to `dynamic_links` and `invites`.
- Updated Gradle build files (Android/firebase_dependencies.gradle, release_build_files/Android/firebase_dependencies.gradle, settings.gradle) to remove `dynamic_links` and `invites` dependencies and resource references.
- Updated build scripts (build_scripts/ios/build.sh, build_scripts/packaging.conf) to remove `dynamic_links`.
- Updated GitHub Actions workflows (.github/workflows/cpp-packaging.yml, .github/workflows/integration_tests.yml) to remove `dynamic_links`.

Next steps involve removing test configurations and documentation related to Dynamic Links and Invites.
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jul 2, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jul 2, 2025
Copy link

github-actions bot commented Jul 2, 2025

❌  Integration test FAILED

Requested by @jonsimantov on commit 12d2bbe
Last updated: Wed Jul 2 13:39 PDT 2025
View integration test log & download artifacts

Failures Configs
missing_log
(7 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [All 2 ssl_lib] [All 2 build_type]
[BUILD] [ERROR] [MacOS] [x64] [boringssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x86, x64] [boringssl]
[BUILD] [ERROR] [iOS] [macos]
[BUILD] [ERROR] [tvOS] [macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 2, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant