Skip to content

Remove deprecated Google Mobile Ads (GMA) C++ SDK #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated Google Mobile Ads (GMA) C++ SDK #1768

wants to merge 1 commit into from

Conversation

jonsimantov
Copy link
Contributor

This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android).

Changes include:

  • Deletion of the core gma directory and its contents.
  • Removal of GMA from CMakeLists.txt files.
  • Removal of GMA from Gradle build files.
  • Removal of GMA from iOS Podfiles.
  • Removal of GMA from integration tests and UI tests.
  • Removal of GMA from build scripts and CI workflows.
  • Updates to documentation (README.md, Doxyfile) to reflect the removal, while preserving release notes related to past GMA versions and adding a new note about its removal.

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-labs-jules
Remove deprecated Google Mobile Ads (GMA) C++ SDK
4f16874 
This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android).

Changes include:
- Deletion of the core `gma` directory and its contents.
- Removal of GMA from CMakeLists.txt files.
- Removal of GMA from Gradle build files.
- Removal of GMA from iOS Podfiles.
- Removal of GMA from integration tests and UI tests.
- Removal of GMA from build scripts and CI workflows.
- Updates to documentation (README.md, Doxyfile) to reflect the removal, while preserving release notes related to past GMA versions and adding a new note about its removal.
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jul 3, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jul 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 45cd7c0
Last updated: Wed Jul 2 17:14 PDT 2025
View integration test log & download artifacts

Failures Configs
missing_log
(7 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [All 2 ssl_lib] [All 2 build_type]
[BUILD] [ERROR] [MacOS] [x64] [boringssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x86, x64] [boringssl]
[BUILD] [ERROR] [iOS] [macos]
[BUILD] [ERROR] [tvOS] [macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 3, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov