Skip to content

Commit 3e147e8

Browse files
authored
[#11887] Removed NSLog Calls from FirebaseAuth (#12249)
1 parent 75f5282 commit 3e147e8

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

FirebaseAuth/Sources/MultiFactor/TOTP/FIRTOTPSecret.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,14 @@ - (void)openInOTPAppWithQRCodeURL:(NSString *)QRCodeURL {
7979
void (*func)(id, SEL, NSURL *, NSDictionary *, void (^)(BOOL)) = (void *)imp;
8080
func(application, selector, url, @{}, nil);
8181
} else {
82-
NSLog(@"Cannot access openURL:options:completionHandler: method");
82+
FIRLogError(kFIRLoggerAuth, @"I-AUT000023",
83+
@"Cannot access openURL:options:completionHandler: method");
8384
}
8485
} else {
85-
NSLog(@"URL cannot be opened");
86+
FIRLogError(kFIRLoggerAuth, @"I-AUT000024", @"URL cannot be opened");
8687
}
8788
} else {
88-
NSLog(@"sharedApplication cannot be accessed");
89+
FIRLogError(kFIRLoggerAuth, @"I-AUT000025", @"sharedApplication cannot be accessed");
8990
}
9091
}
9192

FirebaseAuth/Sources/Utilities/FIRAuthRecaptchaVerifier.m

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,22 @@ - (void)verifyForceRefresh:(BOOL)forceRefresh
122122
}
123123
});
124124
} else {
125-
NSLog(@"reCAPTCHA verification faled because reCAPTCHA SDK "
126-
@"not linked.");
125+
FIRLogError(kFIRLoggerAuth, @"I-AUT000026",
126+
@"reCAPTCHA verification failed because "
127+
@"reCAPTCHA SDK not linked.");
127128
completion(nil,
128129
[FIRAuthErrorUtils recaptchaSDKNotLinkedError]);
129130
}
130131
} else {
131-
NSLog(@"reCAPTCHA verification faled because reCAPTCHA SDK "
132-
@"not linked.");
132+
FIRLogError(kFIRLoggerAuth, @"I-AUT000026",
133+
@"reCAPTCHA verification failed because reCAPTCHA "
134+
@"SDK not linked.");
133135
completion(nil,
134136
[FIRAuthErrorUtils recaptchaSDKNotLinkedError]);
135137
}
136138
} else {
137-
NSLog(@"reCAPTCHA verification succeeded.");
139+
FIRLogInfo(kFIRLoggerAuth, @"I-AUT000027",
140+
@"reCAPTCHA verification succeeded.");
138141
[self retrieveRecaptchaTokenWithAction:action
139142
completion:completion];
140143
}
@@ -160,10 +163,12 @@ - (void)retrieveRecaptchaConfigForceRefresh:(BOOL)forceRefresh
160163
callback:^(FIRGetRecaptchaConfigResponse *_Nullable response,
161164
NSError *_Nullable error) {
162165
if (error) {
163-
NSLog(@"reCAPTCHA config retrieval failed.");
166+
FIRLogError(kFIRLoggerAuth, @"I-AUT000028",
167+
@"reCAPTCHA config retrieval failed.");
164168
completion(error);
165169
}
166-
NSLog(@"reCAPTCHA config retrieval succeeded.");
170+
FIRLogInfo(kFIRLoggerAuth, @"I-AUT000029",
171+
@"reCAPTCHA config retrieval succeeded.");
167172
FIRAuthRecaptchaConfig *config = [[FIRAuthRecaptchaConfig alloc] init];
168173
// Response's site key is of the format projects/<project-id>/keys/<site-key>'
169174
config.siteKey = [response.recaptchaKey componentsSeparatedByString:@"/"][3];
@@ -218,11 +223,13 @@ - (void)retrieveRecaptchaTokenWithAction:(FIRAuthRecaptchaAction)action
218223
execute:customAction
219224
completion:^(NSString *_Nullable token, NSError *_Nullable error) {
220225
if (!error) {
221-
NSLog(@"reCAPTCHA token retrieval succeeded.");
226+
FIRLogInfo(kFIRLoggerAuth, @"I-AUT000030", @"reCAPTCHA token retrieval succeeded.");
222227
completion(token, nil);
223228
return;
224229
} else {
225-
NSLog(@"reCAPTCHA token retrieval failed. NO_RECAPTCHA sent as the fake code.");
230+
FIRLogError(
231+
kFIRLoggerAuth, @"I-AUT000031",
232+
@"reCAPTCHA token retrieval failed. NO_RECAPTCHA sent as the fake code.");
226233
completion(kFakeToken, nil);
227234
}
228235
}];

0 commit comments

Comments
 (0)