Skip to content

Commit 48aa5ed

Browse files
christibbsmaksymmalyhin
authored andcommitted
FIAM Consolidation (#4705)
* Move display SDK source and resources into FIAM SDK * Change files prefixed with FID to be prefixed FIRIAM * Restructure example apps in firebase-ios-sdk directory * Fix directory structure for FIAM * Move proto files into base directory * Fix up proto files * Move unit test files to Firebase/InAppMessaging/Tests * Move FIRIAMSDKModeManagerTests and require app host in podspec * Move sample apps to tests folder * Add empty repo for FIAMDisplay that generates a warning * Fix up functional tests app * Fix up default UI test app * Re-generate protos * Add warning to remove display pod * Remove display podspec from .travis.yml * Remove trailing whitespace * Fix import in test app * Add changes to point to the default test app * Wrap iOS version conditionals * Add line in podspec about deprecation * Delete whitespace in podspec * Delete pods section in project file * Update changelog with consolidation info * Fix indentation in podspecs * Fix some import issues * Fix indent on FirebaseInAppMessaging.podspec * Delete FirebaseInAppMessagingDisplay, update podfile for external test app * Update podfiles, bump iOS min version to 9, remove iOS 9 checks in FIRIAMActionUrlFollowerTests * Add line in CHANGELOG referencing deletion of display sdk pod * Remove unused podfile * Update min version on Podfiles to iOS 9 * Add back FirebaseInAppMessagingDisplay.h * Add iOS support message to CHANGELOG.md * Wrap necessary deprecated iOS 9 call
1 parent 54e2226 commit 48aa5ed

File tree

201 files changed

+528
-257
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

201 files changed

+528
-257
lines changed

.travis.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,6 @@ jobs:
461461
- travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuthInterop.podspec
462462
- travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseCoreDiagnosticsInterop.podspec
463463
- travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec
464-
- travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseInAppMessagingDisplay.podspec
465464

466465
- stage: test
467466
env:
@@ -480,8 +479,6 @@ jobs:
480479
script:
481480
- travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec --use-libraries
482481
- travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec --use-modular-headers
483-
- travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessagingDisplay.podspec --use-libraries
484-
- travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessagingDisplay.podspec --use-modular-headers
485482

486483
- stage: test
487484
if: type = cron

Dangerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,7 @@ has_license_changes = didModify(["LICENSE"])
8080
@has_dynamiclinks_changes = hasChangesIn("Firebase/DynamicLinks/")
8181
@has_firestore_changes = hasChangesIn("Firestore/")
8282
@has_functions_changes = hasChangesIn("Functions/")
83-
@has_inappmessaging_changes = hasChangesIn([
84-
"Firebase/InAppMessaging/",
85-
"Firebase/InAppMessagingDisplay/",
86-
"InAppMessaging/Example/",
87-
"InAppMessagingDisplay/"])
83+
@has_inappmessaging_changes = hasChangesIn(["FirebaseInAppMessaging/"])
8884
@has_installations_changes = hasChangesIn("FirebaseInstallations/Source/")
8985
@has_instanceid_changes = hasChangesIn("Firebase/InstanceID/")
9086
@has_messaging_changes = hasChangesIn("Firebase/Messaging/")

FirebaseInAppMessaging.podspec

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,22 @@ See more product details at https://firebase.google.com/products/in-app-messagin
1717
:tag => 'InAppMessaging-' + s.version.to_s
1818
}
1919
s.social_media_url = 'https://twitter.com/Firebase'
20-
s.ios.deployment_target = '8.0'
20+
s.ios.deployment_target = '9.0'
2121

2222
s.cocoapods_version = '>= 1.4.0'
2323
s.static_framework = true
2424
s.prefix_header_file = false
2525

26-
base_dir = "Firebase/InAppMessaging/"
27-
s.source_files = base_dir + '**/*.[cmh]'
28-
s.public_header_files = base_dir + 'Public/*.h'
26+
base_dir = "FirebaseInAppMessaging/"
27+
s.source_files = base_dir + "Sources/**/*.[cmh]"
28+
s.public_header_files = base_dir + 'Sources/Public/*.h'
29+
s.private_header_files = base_dir + 'Sources/Private/**/*.h'
30+
31+
s.resource_bundles = {
32+
'InAppMessagingDisplayResources' => [ base_dir + 'Resources/*.xib',
33+
base_dir + 'Resources/*.storyboard',
34+
base_dir + 'Resources/*.png']
35+
}
2936

3037
s.pod_target_xcconfig = { 'GCC_PREPROCESSOR_DEFINITIONS' =>
3138
'$(inherited) ' +
@@ -37,5 +44,12 @@ See more product details at https://firebase.google.com/products/in-app-messagin
3744
s.ios.dependency 'FirebaseAnalyticsInterop', '~> 1.3'
3845
s.dependency 'FirebaseInstanceID', '~> 4.0'
3946
s.dependency 'GoogleDataTransportCCTSupport', '~> 1.0'
47+
48+
s.test_spec 'unit' do |unit_tests|
49+
unit_tests.source_files = 'FirebaseInAppMessaging/Tests/Unit/*.[mh]'
50+
unit_tests.resources = 'FirebaseInAppMessaging/Tests/Unit/*.txt'
51+
unit_tests.requires_app_host = true
52+
unit_tests.dependency 'OCMock'
53+
end
4054

4155
end

Firebase/InAppMessaging/Analytics/Protogen/nanopb/fiam.nanopb.c renamed to FirebaseInAppMessaging/Analytics/Protogen/nanopb/fiam.nanopb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const pb_field_t logs_proto_firebase_inappmessaging_ClientAppInfo_fields[3] = {
5454
#if !defined(PB_FIELD_32BIT)
5555
/* If you get an error here, it means that you need to define PB_FIELD_32BIT
5656
* compile-time option. You can do that in pb.h or on compiler command line.
57-
*
57+
*
5858
* The reason you need to do this is that some of your messages contain tag
5959
* numbers or field sizes that are larger than what can fit in 8 or 16 bit
6060
* field descriptors.
@@ -65,7 +65,7 @@ PB_STATIC_ASSERT((pb_membersize(logs_proto_firebase_inappmessaging_CampaignAnaly
6565
#if !defined(PB_FIELD_16BIT) && !defined(PB_FIELD_32BIT)
6666
/* If you get an error here, it means that you need to define PB_FIELD_16BIT
6767
* compile-time option. You can do that in pb.h or on compiler command line.
68-
*
68+
*
6969
* The reason you need to do this is that some of your messages contain tag
7070
* numbers or field sizes that are larger than what can fit in the default
7171
* 8 bit descriptors.

Firebase/InAppMessaging/CHANGELOG.md renamed to FirebaseInAppMessaging/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 2020-01-28 -- v0.16.0
2+
- [changed] Consolidated backend and UI SDKs under `FirebaseInAppMessaging`. Developers should now use `pod Firebase/InAppMessaging` in their Podfile.
3+
- [changed] `FIRIAMDefaultDisplayImpl` is no longer public.
4+
- [changed] `FirebaseInAppMessagingDisplay` is now deprecated and should be removed from developers' Podfiles.
5+
- [changed] Minimum iOS version is now 9.0.
6+
17
# 2019-12-17 -- v0.15.6
28
- [fixed] Issues with nullability in card message (#4435).
39
- [fixed] Unit test failure with OCMock 3.5.0 (#4420).

Firebase/InAppMessaging/ProtoSupport/generate_nanopb_protos.sh renamed to FirebaseInAppMessaging/ProtoSupport/generate_nanopb_protos.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ readonly REPO_DIR="$( git rev-parse --show-toplevel )"
2626
readonly NANOPB_VERSION="0.3.9.3"
2727
readonly NANOPB_TEMPDIR="$(mktemp -d)"
2828

29-
readonly PROTO_DIR="${REPO_DIR}/Firebase/InAppMessaging/ProtoSupport/Protos"
30-
readonly PROTOGEN_DIR="${REPO_DIR}/Firebase/InAppMessaging/Analytics/Protogen"
29+
readonly PROTO_DIR="${REPO_DIR}/FirebaseInAppMessaging/ProtoSupport/Protos"
30+
readonly PROTOGEN_DIR="${REPO_DIR}/FirebaseInAppMessaging/Analytics/Protogen"
3131

3232
rm -rf "${NANOPB_TEMPDIR}"
3333

@@ -45,11 +45,11 @@ echo "Removing existing generated protos..."
4545
rm -rf "${PROTOGEN_DIR}/*"
4646

4747
echo "Generating nanopb protos..."
48-
python "${REPO_DIR}/Firebase/InAppMessaging/ProtoSupport/nanopb_build_protos.py" \
48+
python "${REPO_DIR}/FirebaseInAppMessaging/ProtoSupport/nanopb_build_protos.py" \
4949
--nanopb \
5050
--protos_dir="${PROTO_DIR}" \
5151
--pythonpath="${NANOPB_TEMPDIR}/${NANOPB_BIN_DIR}/generator" \
5252
--output_dir="${PROTOGEN_DIR}" \
5353
--include="${PROTO_DIR}"
5454

55-
rm -rf "${NANOPB_TEMPDIR}"
55+
rm -rf "${NANOPB_TEMPDIR}"

0 commit comments

Comments
 (0)