Skip to content

Commit 6eb257a

Browse files
committed
Todos and workarounds for tests not yet ready for macos-14
1 parent 70f7e77 commit 6eb257a

File tree

5 files changed

+34
-7
lines changed

5 files changed

+34
-7
lines changed

.github/workflows/archiving.yml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,29 @@ jobs:
4646
matrix:
4747
target: [ios, tvos, macos]
4848
# These need to be on a single line or else the formatting won't validate.
49-
pod: ["FirebaseABTesting", "FirebaseAuth", "FirebaseCore", "FirebaseCrashlytics", "FirebaseDatabase", "FirebaseFirestore", "FirebaseFunctions", "FirebaseMessaging", "FirebaseRemoteConfig", "FirebaseStorage"]
49+
pod: ["FirebaseABTesting", "FirebaseAuth", "FirebaseCore", "FirebaseCrashlytics", "FirebaseDatabase", "FirebaseFunctions", "FirebaseMessaging", "FirebaseRemoteConfig", "FirebaseStorage"]
50+
steps:
51+
- uses: actions/checkout@v4
52+
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
53+
with:
54+
cache_key: pods-${{ matrix.os }}
55+
- uses: ruby/setup-ruby@v1
56+
- name: Setup Bundler
57+
run: scripts/setup_bundler.sh
58+
- name: Setup project and archive
59+
run: scripts/test_archiving.sh ${{ matrix.pod }} ${{ matrix.target }} ArchiveOutputs/${{ matrix.target }}.xcarchive
60+
61+
# TODO(#12780: Merge Firestore back into above job after https://github.com/grpc/grpc/pull/36340
62+
pods-ios-tvos-macos-cron-macos12:
63+
# Don't run on private repo.
64+
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule')
65+
66+
runs-on: macos-12
67+
strategy:
68+
matrix:
69+
target: [ios, tvos, macos]
70+
# These need to be on a single line or else the formatting won't validate.
71+
pod: ["FirebaseFirestore"]
5072
steps:
5173
- uses: actions/checkout@v4
5274
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126

.github/workflows/firestore.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ jobs:
326326
if: |
327327
(github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') ||
328328
(github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true')
329-
# TODO(#12769): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
329+
# TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
330330
runs-on: macos-12
331331
needs: check
332332

.github/workflows/functions.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ jobs:
144144
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
145145
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
146146
LEGACY: true
147-
runs-on: macos-14
147+
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
148+
runs-on: macos-12
148149

149150
steps:
150151
- uses: actions/checkout@v4

.github/workflows/prerelease.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ jobs:
1717
specs_checking:
1818
# Don't run on private repo unless it is a PR.
1919
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
20-
runs-on: macos-14
20+
# TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
21+
runs-on: macos-12
2122
env:
2223
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2324
# The SDK repo will be cloned to this dir and podspecs from
@@ -111,7 +112,8 @@ jobs:
111112
needs: [buildup_SpecsTesting_repo_FirebaseCore, specs_checking]
112113
# Don't run on private repo unless it is a PR.
113114
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
114-
runs-on: macos-14
115+
# TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
116+
runs-on: macos-12
115117
strategy:
116118
fail-fast: false
117119
matrix: ${{fromJson(needs.specs_checking.outputs.matrix)}}

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ jobs:
1919
specs_checking:
2020
# Don't run on private repo unless it is a PR.
2121
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
22-
runs-on: macos-14
22+
# TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
23+
runs-on: macos-12
2324
env:
2425
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2526
# The SDK repo will be cloned to this dir and podspecs from
@@ -113,7 +114,8 @@ jobs:
113114
needs: [buildup_SpecsTesting_repo_FirebaseCore, specs_checking]
114115
# Don't run on private repo unless it is a PR.
115116
if: github.repository == 'Firebase/firebase-ios-sdk'
116-
runs-on: macos-14
117+
# TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340
118+
runs-on: macos-12
117119
strategy:
118120
fail-fast: false
119121
matrix: ${{fromJson(needs.specs_checking.outputs.matrix)}}

0 commit comments

Comments
 (0)