refactor: Remove is_legacy QS testing flags (#15353)

Author: ncooke3

.github/workflows/abtesting.yml

@@ -45,8 +45,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: ABTesting
-      is_legacy: true
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh abtesting
+      setup_command: scripts/setup_quickstart_spm.sh abtesting
       plist_src_path: scripts/gha-encrypted/qs-abtesting.plist.gpg
       plist_dst_path: quickstart-ios/abtesting/GoogleService-Info.plist
     secrets:
@@ -67,7 +66,6 @@ jobs:
   #       python-version: '3.11'
   #   - name: Setup quickstart
   #     env:
-  #       LEGACY: true
   #     run: scripts/setup_quickstart.sh abtesting
   #   - name: Install Secret GoogleService-Info.plist
   #     run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \
@@ -76,7 +74,6 @@ jobs:
   #     run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
   #   - name: Build swift quickstart
   #     env:
-  #       LEGACY: true
   #     run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh ABTesting)
   #   - id: ftl_test
   #     uses: FirebaseExtended/github-actions/firebase-test-lab@v1.4

.github/workflows/auth.yml

@@ -97,8 +97,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: Authentication
-      is_legacy: false
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh authentication
+      setup_command: scripts/setup_quickstart_spm.sh authentication
       plist_src_path: scripts/gha-encrypted/qs-authentication.plist.gpg
       plist_dst_path: quickstart-ios/authentication/GoogleService-Info.plist
       run_tests: false

.github/workflows/common_quickstart.yml

@@ -29,10 +29,12 @@ on:
         type: string
         required: true
 
-      # Whether to test the legacy version of the quickstart.
-      is_legacy:
-        type: boolean
-        required: true
+      # The branch to checkout in the quickstart repo.
+      quickstart_branch:
+        type: string
+        required: false
+        # default: 'main' # TODO: Revert to main before merging.
+        default: 'nc/quickstarts'
 
       # The path to the encrypted `GoogleService-Info.plist` file.
       plist_src_path:
@@ -60,11 +62,12 @@ on:
 
 jobs:
   quickstart:
+    name: quickstart (${{ inputs.product }})
     # Run on the main repo's scheduled jobs or pull requests and manual workflow invocations.
     if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
     env:
       plist_secret: ${{ secrets.plist_secret }}
-      LEGACY: ${{ inputs.is_legacy && true || '' }}
+      QUICKSTART_BRANCH: ${{ inputs.quickstart_branch }}
     runs-on: macos-15
     steps:
     - uses: actions/checkout@v4
@@ -81,7 +84,7 @@ jobs:
             ${{ inputs.plist_src_path }} \
             ${{ inputs.plist_dst_path }} \
             "$plist_secret"
-    - name: Build ${{ inputs.product }} Quickstart (${{ inputs.is_legacy && 'Legacy' || 'Non-Legacy' }})
+    - name: Build ${{ inputs.product }} Quickstart
       uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
       with:
         timeout_minutes: 15
@@ -90,7 +93,7 @@ jobs:
         command: |
           SPM=true DIR=${{ inputs.product }} scripts/test_quickstart.sh \
             ${{ inputs.product }} \
-            ${{ inputs.run_tests }} \
+            ${{ inputs.run_tests }}
     # Failure sequence to upload artifact.
     - id: lowercase_product
       if: ${{ failure() }}

.github/workflows/crashlytics.yml

@@ -47,13 +47,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: Crashlytics
-      is_legacy: true
-      setup_command: |
-        scripts/setup_quickstart.sh crashlytics
-        mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics
-        # Set the deployed pod location of run and upload-symbols with the development pod version.
-        cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
-        cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
+      setup_command: scripts/setup_quickstart_spm.sh crashlytics
       plist_src_path: scripts/gha-encrypted/qs-crashlytics.plist.gpg
       plist_dst_path: quickstart-ios/crashlytics/GoogleService-Info.plist
     secrets:
@@ -76,20 +70,12 @@ jobs:
   #     run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
   #   - name: Setup quickstart
   #     run: scripts/setup_quickstart.sh crashlytics
-  #     env:
-  #       LEGACY: true
   #   - name: Install Secret GoogleService-Info.plist
   #     run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \
   #         quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret"
   #   - name: Build swift quickstart
   #     run: |
-  #       mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics
-  #       # Set the deployed pod location of run and upload-symbols with the development pod version.
-  #       cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
-  #       cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
   #       ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Crashlytics swift)
-  #     env:
-  #       LEGACY: true
   #   - id: ftl_test
   #     uses: FirebaseExtended/github-actions/firebase-test-lab@v1.4
   #     with:

.github/workflows/database.yml

@@ -74,8 +74,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: Database
-      is_legacy: false
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh database
+      setup_command: scripts/setup_quickstart_spm.sh database
       plist_src_path: scripts/gha-encrypted/qs-database.plist.gpg
       plist_dst_path: quickstart-ios/database/GoogleService-Info.plist
       run_tests: false

.github/workflows/firestore.yml

@@ -605,8 +605,7 @@ jobs:
   #   uses: ./.github/workflows/common_quickstart.yml
   #   with:
   #     product: Firestore
-  #     is_legacy: true
-  #     setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh firestore
+  #     setup_command: scripts/setup_quickstart_spm.sh firestore
   #     plist_src_path: scripts/gha-encrypted/qs-firestore.plist.gpg
   #     plist_dst_path: quickstart-ios/firestore/GoogleService-Info.plist
   #     run_tests: false

.github/workflows/functions.yml

@@ -51,23 +51,7 @@ jobs:
     with:
       target: FirebaseFunctionsUnit
 
-  # TODO: The legacy quickstart uses material which doesn't build on Xcode 15.
-  # quickstart:
-  #     uses: ./.github/workflows/common_quickstart.yml
-  #     strategy:
-  #       matrix:
-  #         quickstart_type: [objc, swift]
-  #     with:
-  #       product: Functions
-  #       is_legacy: true
-  #       setup_command: |
-  #         scripts/setup_quickstart.sh functions
-  #         sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
-  #       plist_src_path: scripts/gha-encrypted/qs-functions.plist.gpg
-  #       plist_dst_path: quickstart-ios/functions/GoogleService-Info.plist
-  #       quickstart_type: ${{ matrix.quickstart_type }}
-  #     secrets:
-  #       plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
+  # TODO(ncooke3): Add a Functions quickstart test.
 
   # quickstart-ftl-cron-only:
   #   # Don't run on private repo

.github/workflows/inappmessaging.yml

@@ -76,8 +76,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: InAppMessaging
-      is_legacy: false
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh inappmessaging
+      setup_command: scripts/setup_quickstart_spm.sh inappmessaging
       plist_src_path: scripts/gha-encrypted/qs-inappmessaging.plist.gpg
       plist_dst_path: quickstart-ios/inappmessaging/GoogleService-Info.plist
     secrets:

.github/workflows/installations.yml

@@ -53,8 +53,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: Installations
-      is_legacy: false
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh installations
+      setup_command: scripts/setup_quickstart_spm.sh installations
       plist_src_path: scripts/gha-encrypted/Installations/GoogleService-Info.plist.gpg
       plist_dst_path: quickstart-ios/installations/GoogleService-Info.plist
     secrets:

.github/workflows/messaging.yml

@@ -85,8 +85,7 @@ jobs:
     uses: ./.github/workflows/common_quickstart.yml
     with:
       product: Messaging
-      is_legacy: false
-      setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh messaging
+      setup_command: scripts/setup_quickstart_spm.sh messaging
       plist_src_path: scripts/gha-encrypted/qs-messaging.plist.gpg
       plist_dst_path: quickstart-ios/messaging/GoogleService-Info.plist
       run_tests: false