Skip to content

Commit b6e5270

Browse files
authored
[AppCheck] Migrate to GoogleUtilities's storage container (#12773)
1 parent 3211a7f commit b6e5270

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

FirebaseAppCheck.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ Pod::Spec.new do |s|
4848
s.dependency 'FirebaseAppCheckInterop', '~> 10.17'
4949
s.dependency 'FirebaseCore', '~> 10.0'
5050
s.dependency 'PromisesObjC', '~> 2.1'
51-
s.dependency 'GoogleUtilities/Environment', '~> 7.8'
51+
s.dependency 'GoogleUtilities/Environment', '~> 7.13'
52+
s.dependency 'GoogleUtilities/UserDefaults', '~> 7.13'
5253

5354
s.pod_target_xcconfig = {
5455
'GCC_C_LANGUAGE_STANDARD' => 'c99',

FirebaseAppCheck/Sources/Core/FIRAppCheck.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
#import <AppCheckCore/AppCheckCore.h>
2020
#import <FirebaseAppCheckInterop/FirebaseAppCheckInterop.h>
21+
#import <GoogleUtilities/GULUserDefaults.h>
2122

2223
#import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckErrors.h"
2324
#import "FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckProvider.h"
@@ -92,7 +93,7 @@ - (nullable instancetype)initWithApp:(FIRApp *)app {
9293
[[FIRInternalAppCheckProvider alloc] initWithAppCheckProvider:appCheckProvider];
9394
FIRAppCheckSettings *settings =
9495
[[FIRAppCheckSettings alloc] initWithApp:app
95-
userDefault:[NSUserDefaults standardUserDefaults]
96+
userDefault:[GULUserDefaults standardUserDefaults]
9697
mainBundle:[NSBundle mainBundle]];
9798

9899
GACAppCheck *appCheckCore = [[GACAppCheck alloc] initWithServiceName:serviceName

FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#import <AppCheckCore/AppCheckCore.h>
2020

2121
@class FIRApp;
22+
@class GULUserDefaults;
2223

2324
NS_ASSUME_NONNULL_BEGIN
2425

@@ -32,7 +33,7 @@ FOUNDATION_EXPORT NSString *const kFIRAppCheckTokenAutoRefreshEnabledInfoPlistKe
3233
@property(nonatomic, assign) BOOL isTokenAutoRefreshEnabled;
3334

3435
- (instancetype)initWithApp:(FIRApp *)firebaseApp
35-
userDefault:(NSUserDefaults *)userDefaults
36+
userDefault:(GULUserDefaults *)userDefaults
3637
mainBundle:(NSBundle *)mainBundle NS_DESIGNATED_INITIALIZER;
3738

3839
- (instancetype)init NS_UNAVAILABLE;

FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
#import "FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.h"
1818

19+
#import <GoogleUtilities/GULUserDefaults.h>
20+
1921
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
2022

2123
NS_ASSUME_NONNULL_BEGIN
@@ -28,7 +30,7 @@
2830
@interface FIRAppCheckSettings ()
2931

3032
@property(nonatomic, weak, readonly) FIRApp *firebaseApp;
31-
@property(nonatomic, readonly) NSUserDefaults *userDefaults;
33+
@property(nonatomic, readonly) GULUserDefaults *userDefaults;
3234
@property(nonatomic, readonly) NSBundle *mainBundle;
3335
@property(nonatomic, readonly) NSString *userDefaultKey;
3436
@property(nonatomic, assign) BOOL isTokenAutoRefreshConfigured;
@@ -38,7 +40,7 @@ @interface FIRAppCheckSettings ()
3840
@implementation FIRAppCheckSettings
3941

4042
- (instancetype)initWithApp:(FIRApp *)firebaseApp
41-
userDefault:(NSUserDefaults *)userDefaults
43+
userDefault:(GULUserDefaults *)userDefaults
4244
mainBundle:(NSBundle *)mainBundle {
4345
self = [super init];
4446
if (self) {

FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckSettingsTests.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#import <XCTest/XCTest.h>
1818

19+
#import <GoogleUtilities/GULUserDefaults.h>
1920
#import <OCMock/OCMock.h>
2021

2122
#import "FirebaseAppCheck/Sources/Core/FIRAppCheckSettings.h"
@@ -46,7 +47,7 @@ - (void)setUp {
4647

4748
self.mockApp = OCMClassMock([FIRApp class]);
4849
OCMStub([self.mockApp name]).andReturn(self.appName);
49-
self.mockUserDefaults = OCMClassMock([NSUserDefaults class]);
50+
self.mockUserDefaults = OCMClassMock([GULUserDefaults class]);
5051
self.bundleMock = OCMClassMock([NSBundle class]);
5152

5253
self.settings = [[FIRAppCheckSettings alloc] initWithApp:self.mockApp

Package.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1290,6 +1290,7 @@ let package = Package(
12901290
.product(name: "AppCheckCore", package: "app-check"),
12911291
.product(name: "FBLPromises", package: "Promises"),
12921292
.product(name: "GULEnvironment", package: "GoogleUtilities"),
1293+
.product(name: "GULUserDefaults", package: "GoogleUtilities"),
12931294
],
12941295
path: "FirebaseAppCheck/Sources",
12951296
publicHeadersPath: "Public",

0 commit comments

Comments
 (0)