Skip to content

Commit daf1b68

Browse files
committed
revert test settings
1 parent e699c17 commit daf1b68

File tree

5 files changed

+18
-6
lines changed

5 files changed

+18
-6
lines changed

Firestore/Example/Firestore.xcodeproj/xcshareddata/xcschemes/Firestore_Example_iOS.xcscheme

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,18 @@
8989
ReferencedContainer = "container:Firestore.xcodeproj">
9090
</BuildableReference>
9191
</BuildableProductRunnable>
92+
<EnvironmentVariables>
93+
<EnvironmentVariable
94+
key = "PROJECT_ID"
95+
value = "firestore-sdk-nightly"
96+
isEnabled = "YES">
97+
</EnvironmentVariable>
98+
<EnvironmentVariable
99+
key = "TARGET_BACKEND"
100+
value = "nightly"
101+
isEnabled = "YES">
102+
</EnvironmentVariable>
103+
</EnvironmentVariables>
92104
</LaunchAction>
93105
<ProfileAction
94106
buildConfiguration = "Release"

Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
static const double kPrimingTimeout = 45.0;
8686

8787
static NSString *defaultProjectId;
88-
static NSString *defaultDatabaseId = @"enterprise";
88+
static NSString *defaultDatabaseId = @"(default)";
8989
static FIRFirestoreSettings *defaultSettings;
9090

9191
static bool runningAgainstEmulator = false;

Firestore/core/src/api/ordering.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
#ifndef FIRESTORE_CORE_SRC_API_ORDERING_H_
1818
#define FIRESTORE_CORE_SRC_API_ORDERING_H_
1919

20+
#include <memory>
21+
#include <string>
2022
#include <utility>
2123

2224
#include "Firestore/core/src/api/expressions.h"
@@ -26,8 +28,6 @@ namespace firebase {
2628
namespace firestore {
2729
namespace api {
2830

29-
class UserDataReader; // forward declaration
30-
3131
class Ordering {
3232
public:
3333
enum Direction {

Firestore/core/src/api/stages.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,8 @@ ReplaceWith::ReplaceWith(std::string field_name)
332332
: expr_(nullptr), field_name_(std::move(field_name)) {
333333
}
334334

335-
Sample::Sample(std::string type, int64_t count, double percentage_)
336-
: type_(type), count_(count), percentage_(percentage_) {
335+
Sample::Sample(std::string type, int64_t count, double percentage)
336+
: type_(type), count_(count), percentage_(percentage) {
337337
}
338338

339339
google_firestore_v1_Pipeline_Stage Sample::to_proto() const {

Firestore/core/src/api/stages.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ class ReplaceWith : public Stage {
264264

265265
class Sample : public Stage {
266266
public:
267-
Sample(std::string type, int64_t count, double percentage_);
267+
Sample(std::string type, int64_t count, double percentage);
268268
~Sample() override = default;
269269
google_firestore_v1_Pipeline_Stage to_proto() const override;
270270

0 commit comments

Comments
 (0)