infra: Fix zip's ai artifact name and do not upload service plists (#15492)

Author: ncooke3

.github/workflows/common_quickstart.yml

@@ -100,15 +100,17 @@ jobs:
             ${{ inputs.quickstart_type }}
     # Failure sequence to upload artifact.
     - id: lowercase_product
-      if: ${{ failure() }}
+      if: failure()
       run: |
         lowercase_product=$(echo "${{ inputs.product }}" | tr '[:upper:]' '[:lower:]')
         echo "lowercase_product=$lowercase_product" >> $GITHUB_OUTPUT
     - name: Remove data before upload.
-      if: ${{ failure() }}
+      if: failure()
       run: scripts/remove_data.sh ${{ steps.lowercase_product.outputs.lowercase_product }}
     - uses: actions/upload-artifact@v4
-      if: ${{ failure() }}
+      if: failure()
       with:
         name: quickstart_artifacts_${{ steps.lowercase_product.outputs.lowercase_product }}
-        path: quickstart-ios/
+        path: |
+          quickstart-ios/
+          !quickstart-ios/**/GoogleService-Info.plist

.github/workflows/prerelease_cocoapods.yml

@@ -340,10 +340,12 @@ jobs:
         command: scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
     # Failure sequence to upload artifact.
     - name: Remove data before upload.
-      if: ${{ failure() }}
+      if: failure()
       run: scripts/remove_data.sh ${{ matrix.product }}
     - uses: actions/upload-artifact@v4
-      if: ${{ failure() }}
+      if: failure()
       with:
         name: quickstart_artifacts_${{ matrix.product }}
-        path: quickstart-ios/
+        path: |
+          quickstart-ios/
+          !quickstart-ios/**/GoogleService-Info.plist

.github/workflows/release_cocoapods.yml

@@ -237,13 +237,15 @@ jobs:
         retry_wait_seconds: 120
         command: scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }} swift
     - name: Remove data before upload
-      if: ${{ failure() }}
+      if: failure()
       run: scripts/remove_data.sh ${{ matrix.product }}
     - uses: actions/upload-artifact@v4
-      if: ${{ failure() }}
+      if: failure()
       with:
         name: quickstart_artifacts_${{ matrix.product }}
-        path: quickstart-ios/
+        path: |
+          quickstart-ios/
+          !quickstart-ios/**/GoogleService-Info.plist
 
   # TODO: The functions quickstart uses Material which isn't supported by Xcode 15
   # functions_quickstart:

.github/workflows/zip.yml

@@ -509,13 +509,15 @@ jobs:
     - name: Test Quickstart
       run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
     - name: Remove data before upload
-      if: ${{ failure() }}
+      if: failure()
       run: scripts/remove_data.sh firebaseai
     - uses: actions/upload-artifact@v4
-      if: ${{ failure() }}
+      if: failure()
       with:
-        name: quickstart_artifacts_firebaseai
-        path: quickstart-ios/
+        name: quickstart_artifacts_firebaseai_${{ matrix.artifact }}_${{ matrix.build-env.os }}
+        path: |
+          quickstart-ios/
+          !quickstart-ios/**/GoogleService-Info.plist
 
   quickstart_framework_firestore:
     needs: packaging_done