Skip to content

Commit f00f8ce

Browse files
wilhuffpaulb777
authored andcommitted
Fix connectivity monitor redispatching. (#3665)
* Fix connectivity monitor redispatching. In #3467, we changed the connectivity monitor to take callbacks from SCNetworkReachability on the main thread but didn't make the corresponding change to enqueue the notification back onto Firestore's worker. * Bump patch version * CHANGELOG
1 parent eb715c7 commit f00f8ce

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

FirebaseFirestore.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'FirebaseFirestore'
3-
s.version = '1.4.4'
3+
s.version = '1.4.5'
44
s.summary = 'Google Cloud Firestore for iOS'
55

66
s.description = <<-DESC

Firestore/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Unreleased
22

3+
# v1.4.5
4+
- [fixed] Fixed a crash that would happen when changing networks or going from
5+
online to offline. (#3661).
6+
37
# v1.4.4
48
- [changed] Internal improvements.
59

Firestore/core/src/firebase/firestore/remote/connectivity_monitor_apple.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ explicit ConnectivityMonitorApple(
124124
}
125125

126126
void OnReachabilityChanged(SCNetworkReachabilityFlags flags) {
127-
queue()->ExecuteBlocking(
127+
queue()->Enqueue(
128128
[this, flags] { MaybeInvokeCallbacks(ToNetworkStatus(flags)); });
129129
}
130130

0 commit comments

Comments
 (0)