Skip to content

fix passkey name caching issue #12681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix passkey name caching issue #12681

merged 3 commits into from
Apr 2, 2024

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Fix the provided passkey name not being cached issue. Added more unit tests to guard this.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review April 2, 2024 18:16
@Xiaoshouzi-gh Xiaoshouzi-gh requested a review from renkelvin April 2, 2024 18:16
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit 1229604 into passkey Apr 2, 2024
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-name-fix branch April 2, 2024 20:14
@firebase firebase locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaoshouzi-gh @google-oss-bot @renkelvin