From 6eb257aab23c04a805aad48cdc2f231b683365be Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Sat, 13 Apr 2024 07:47:09 -0700 Subject: [PATCH] Todos and workarounds for tests not yet ready for macos-14 --- .github/workflows/archiving.yml | 24 +++++++++++++++++++++++- .github/workflows/firestore.yml | 2 +- .github/workflows/functions.yml | 3 ++- .github/workflows/prerelease.yml | 6 ++++-- .github/workflows/release.yml | 6 ++++-- 5 files changed, 34 insertions(+), 7 deletions(-) diff --git a/.github/workflows/archiving.yml b/.github/workflows/archiving.yml index 8d60f6785b4..0d8a7eeddcf 100644 --- a/.github/workflows/archiving.yml +++ b/.github/workflows/archiving.yml @@ -46,7 +46,29 @@ jobs: matrix: target: [ios, tvos, macos] # These need to be on a single line or else the formatting won't validate. - pod: ["FirebaseABTesting", "FirebaseAuth", "FirebaseCore", "FirebaseCrashlytics", "FirebaseDatabase", "FirebaseFirestore", "FirebaseFunctions", "FirebaseMessaging", "FirebaseRemoteConfig", "FirebaseStorage"] + pod: ["FirebaseABTesting", "FirebaseAuth", "FirebaseCore", "FirebaseCrashlytics", "FirebaseDatabase", "FirebaseFunctions", "FirebaseMessaging", "FirebaseRemoteConfig", "FirebaseStorage"] + steps: + - uses: actions/checkout@v4 + - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 + with: + cache_key: pods-${{ matrix.os }} + - uses: ruby/setup-ruby@v1 + - name: Setup Bundler + run: scripts/setup_bundler.sh + - name: Setup project and archive + run: scripts/test_archiving.sh ${{ matrix.pod }} ${{ matrix.target }} ArchiveOutputs/${{ matrix.target }}.xcarchive + + # TODO(#12780: Merge Firestore back into above job after https://github.com/grpc/grpc/pull/36340 + pods-ios-tvos-macos-cron-macos12: + # Don't run on private repo. + if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') + + runs-on: macos-12 + strategy: + matrix: + target: [ios, tvos, macos] + # These need to be on a single line or else the formatting won't validate. + pod: ["FirebaseFirestore"] steps: - uses: actions/checkout@v4 - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index c092c47e614..f4641697a1b 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -326,7 +326,7 @@ jobs: if: | (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || (github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true') - # TODO(#12769): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 + # TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 runs-on: macos-12 needs: check diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index bf1a1359de7..915b25118e1 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -144,7 +144,8 @@ jobs: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} LEGACY: true - runs-on: macos-14 + # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15. + runs-on: macos-12 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml index 74633f10bd3..132548b25bc 100644 --- a/.github/workflows/prerelease.yml +++ b/.github/workflows/prerelease.yml @@ -17,7 +17,8 @@ jobs: specs_checking: # Don't run on private repo unless it is a PR. if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch' - runs-on: macos-14 + # TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 + runs-on: macos-12 env: bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} # The SDK repo will be cloned to this dir and podspecs from @@ -111,7 +112,8 @@ jobs: needs: [buildup_SpecsTesting_repo_FirebaseCore, specs_checking] # Don't run on private repo unless it is a PR. if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch' - runs-on: macos-14 + # TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 + runs-on: macos-12 strategy: fail-fast: false matrix: ${{fromJson(needs.specs_checking.outputs.matrix)}} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2bacbdd8ef4..745e49472d7 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,7 +19,8 @@ jobs: specs_checking: # Don't run on private repo unless it is a PR. if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch' - runs-on: macos-14 + # TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 + runs-on: macos-12 env: bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} # The SDK repo will be cloned to this dir and podspecs from @@ -113,7 +114,8 @@ jobs: needs: [buildup_SpecsTesting_repo_FirebaseCore, specs_checking] # Don't run on private repo unless it is a PR. if: github.repository == 'Firebase/firebase-ios-sdk' - runs-on: macos-14 + # TODO(#12780): macOS 14 blocked on https://github.com/grpc/grpc/pull/36340 + runs-on: macos-12 strategy: fail-fast: false matrix: ${{fromJson(needs.specs_checking.outputs.matrix)}}