Skip to content

[InAppMessaging] Follow-up to #12910 #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ncooke3 merged 3 commits into from
May 8, 2024
Merged

[InAppMessaging] Follow-up to #12910 #12917

ncooke3 merged 3 commits into from
May 8, 2024

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 8, 2024 •
edited
Loading

Address feedback in ab94a58#r141810158

#no-changelog

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label May 8, 2024
@ncooke3 ncooke3 requested a review from paulb777 May 8, 2024 16:07
paulb777
paulb777 approved these changes May 8, 2024
View reviewed changes
ncooke3
ncooke3 commented May 8, 2024
View reviewed changes
@google-oss-bot
Copy link
Collaborator

google-oss-bot commented May 8, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from 44.62% (1c605b2) to 44.42% (7bd673c) by -0.20%.

    FilenameBase (1c605b2)Merge (7bd673c)Diff
    FIRIAMDefaultDisplayImpl.m1.75%1.63%-0.12%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ua8ArQhmKk.html

@ncooke3 ncooke3 merged commit 2bac0dd into main May 8, 2024
@ncooke3 ncooke3 deleted the nc/fiam-feedback branch May 8, 2024 18:57
ncooke3 added a commit that referenced this pull request May 8, 2024
@ncooke3
[InAppMessaging] Follow-up to #12910 (#12917)
08014e7
@ncooke3 ncooke3 mentioned this pull request May 8, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: inappmessaging Firebase In App Messaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncooke3 @google-oss-bot @paulb777