Skip to content

[Vertex AI] Read golden files from vertexai subdirectory #14582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

andrewheard
Copy link
Contributor

Added a subdirectory parameter to GenerativeModelTests.httpRequestHandler(...) to handle the new directory structure of the Vertex AI golden files (mock responses) being introduced in FirebaseExtended/vertexai-sdk-test-data#30. The Vertex AI-specific files now reside in a vertexai subdirectory.

Note: Needed to switch from process to copy in Package.swift in order to retain the directory structure, which avoids duplicate file errors. Unlike process, copy doesn't flatten the resources into the top level.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@paulb777
Copy link
Member

Test failures

@paulb777
Copy link
Member

nvm, I see the note in FirebaseExtended/vertexai-sdk-test-data#30

@andrewheard
Copy link
Contributor Author

Test failures

nvm, I see the note in FirebaseExtended/vertexai-sdk-test-data#30

Fortunately this situation hasn't come up too often despite us not being versioned like JS / Android. I'll kick off the CI re-runs as soon as it gets merged.

@andrewheard andrewheard merged commit 3bc52e3 into main Mar 17, 2025
61 checks passed
@andrewheard andrewheard deleted the ah/vertex-golden-dir branch March 17, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants