Skip to content

[Swift 6] Add AtomicBox to CoreInternal #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

[Swift 6] Add AtomicBox to CoreInternal #14594

merged 3 commits into from
Mar 19, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 18, 2025

Plan: Add AtomicBox to each module as needed as part of addressing Swift 6 warnings. Then, when we move to Xcode 16, delete all definitions of AtomicBox apart from the one defined in this PR, in FirebaseCoreInternal. Reason being is that Xcode 16 gives us Swift 6 support for internal import FirebaseCoreInternal in other product SDKs that can then get AtomicBox.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 requested a review from paulb777 March 19, 2025 14:29
@ncooke3 ncooke3 merged commit b01a8f2 into main Mar 19, 2025
66 checks passed
@ncooke3 ncooke3 deleted the nc/atomic-box branch March 19, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants