-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Infra] Build binaries with Xcode 16.2 x macos-14 #14606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit b04e597.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - assuming the other two boxes will be done separately
# Unreleased | ||
- [changed] Firebase now requires at least Xcode 16.2. See | ||
https://developer.apple.com/news/?id=9s0rgdy9 for more info. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mikehardy, heads up that firebase-ios-sdk's 10.12 release will require Xcode 16.2. This is in preparation for Apple's April 24 deadline to start releasing apps with Xcode 16: https://developer.apple.com/news/?id=9s0rgdy9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - thanks for the heads up - we've got another similarly-tiny but nevertheless breaking change queued up over in react-native-firebase and I was looking for something/anything to bundle with it, this fits the bill.
@@ -36,8 +36,8 @@ jobs: | |||
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncooke3 just noticed this - wasn't expecting to see my name in your yaml 😆
Just a note that I've deprecated that action because I consider ccache to be superior due to more widespread adoption vs buildcache. Used to be ccache couldn't handle caching Xcode mobile builds so buildcache was the only option, but there is now a well-known set of options to use for ccache to achieve good caching behavior
Here is my ccache.conf if that helps:
max_size = 60G
sloppiness = clang_index_store,file_stat_matches,include_file_ctime,include_file_mtime,ivfsoverlay,pch_defines,modules,system_headers,time_macros
file_clone = true
depend_mode = true
inode_cache = true
alternatively you may specify all these things in environment like so:
in combo with ccache-action:
then the only other trick is to use relative paths for CC/CPLUSPLUS/LD/LDPLUSPLUS so that the ccache compiler/linker symlinks will be used instead of the real underlying compiler/linker
Example of that but it's environment too so lots of ways to achieve it:
https://github.com/invertase/react-native-firebase/blob/c26253c82f0a13f62608941d266a63071667cc16/package.json#L57
Hopefully that helps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Mike! I will take a look at migrating the usage.
Follow-up work
#no-changelog