Fix cases of multiple stubs on the same method on a mock

[paulb777]

See internal cl/743729906

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

[paulb777]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request addresses an issue where multiple stubs were being defined on the same method of a mock object in the FirebaseCore testing suite. The change replaces OCMStub with OCMExpect in the FIRBundleUtilTest.m file. This ensures that the mock expectations are properly verified during testing, preventing unexpected behavior when multiple stubs are defined for the same method.

Highlights

• Bug Fix: Replaces OCMStub with OCMExpect to fix issues with multiple stubs on the same mock method.
• Testing: Ensures mock expectations are properly verified in FIRBundleUtilTest.m.

Changelog

• FirebaseCore/Tests/Unit/FIRBundleUtilTest.m
  • Replaced OCMStub with OCMExpect for bundleIdentifier method calls on self.mockBundle to ensure proper mock verification.

Activity

• The pull request was created by paulb777 to address an internal issue (cl/743729906).
• gemini-code-assist[bot] provided a welcome message with information on how to use Gemini Code Assist.
• paulb777 requested a summary from gemini-code-assist[bot].

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

The pull request addresses an issue where multiple stubs were being set on the same method of a mock object in the tests. This change replaces OCMStub with OCMExpect to ensure that the expected number of calls to the mocked method are verified. This is a good change to improve the accuracy and reliability of the tests.

Summary of Findings

• OCMStub vs OCMExpect: The change replaces OCMStub with OCMExpect. OCMStub only stubs the method, whereas OCMExpect verifies that the method is called the expected number of times. This is important for ensuring that the code under test is behaving as expected.

Merge Readiness

The code changes are well-done and address the issue of multiple stubs on the same method. I recommend merging this pull request after addressing the review comments. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger