[Infra] Move --legacy flag into xcresulttool_json function

[andrewheard]

PR #14717 didn't cover the following codepath:

firebase-ios-sdk/scripts/xcresult_logs.py

Lines 220 to 229 in 3636aa7

	def find_log_id(xcresult_path):
	"""Finds the id of the last action's logs.
	Args:
	xcresult_path: The path to an xcresult bundle.
	Returns:
	The id of the log output, suitable for use with xcresulttool get --id.
	"""
	parsed = xcresulttool_json('get', '--path', xcresult_path)

In this case the --legacy flag wasn't getting added, resulting in the failures in #14661 (e.g., https://github.com/firebase/firebase-ios-sdk/actions/runs/14510030575/job/40734103865#step:10:9303). Moving the --legacy flag into xcresulttool_json(...) should fix the remaining failures.

#no-changelog

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

[andrewheard]

The database integration test now passes: https://github.com/firebase/firebase-ios-sdk/actions/runs/14520173660/job/40738948047?pr=14736

[paulb777]

CI failure seems unrelated

[andrewheard]

CI failure seems unrelated

@paulb777 Agreed. Also double checked that the failing test passed after the Firestore PR last night https://github.com/firebase/firebase-ios-sdk/actions/runs/14505972666/job/40695448604.