Skip to content

[Infra] Add support for manual dispatch to new re-usable SPM workflow #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 23, 2025

Address TODO in #14739

I recently added manual workflow dispatch to all workflows. But since our jobs run on a condition (only scheduled Firebase CI or pull requests), we need to update all the conditions. The reusable workflow makes this easy since it's shared for all jobs.

Example invocation in https://github.com/firebase/firebase-ios-sdk/actions/runs/14620856096

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 requested a review from paulb777 April 23, 2025 14:37
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the permissions warning not matter because it's controlled by the callers always?

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 23, 2025

@paulb777 , where do you see permission warning?

@paulb777
Copy link
Member

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 23, 2025

Thanks, @paulb777 . I've set permission to read-only.

@ncooke3 ncooke3 merged commit a6c8725 into main Apr 23, 2025
25 checks passed
@ncooke3 ncooke3 deleted the ncooke3-patch-4 branch April 23, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants