Skip to content

[Firebase AI] Fix integration tests and re-enable Dev API configs #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

andrewheard
Copy link
Contributor

  • Updated testCountTokens_functionCalling to check that the token count is > 0.
    • This will make the test more resilient to backend changes in token counting.
  • Re-enabled Developer API configs since the backend issues have been resolved.
  • Disabled Vertex AI configs for generateImage since the backend returns empty SafetyRatings in the array, which breaks our decoding.
    • Note 1: This behaviour does not appear to occur with production models -- this test uses the experimental Gemini 2.0 Flash model with Image Generation support (gemini-2.0-flash-exp).
    • Note 2: This issue is not observed on Google AI (Developer API).

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard marked this pull request as ready for review April 30, 2025 19:08
@andrewheard andrewheard requested a review from paulb777 April 30, 2025 19:08
@andrewheard andrewheard merged commit 24e9c93 into main Apr 30, 2025
59 of 60 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-fix-integration-tests branch April 30, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants