-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Firebase AI] Add GenerativeModel
tests using Dev API mock responses
#14816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new tests for GenerativeModel
using mock responses for both Google AI and Vertex AI backends. The code is well-structured and the tests cover various success and failure scenarios. However, there are a few areas that could be improved for better maintainability and clarity.
Summary of Findings
- Duplicated
httpRequestHandler
andnonHTTPRequestHandler
functions: ThehttpRequestHandler
andnonHTTPRequestHandler
functions are duplicated inGenerativeModelVertexAITests.swift
and were moved toGenerativeModelTestUtil.swift
. Ensure that all call sites are updated to use the utility functions to avoid future duplication. - Inconsistent use of
GenerativeModelTestUtil.testFirebaseInfo()
: ThetestFirebaseInfo()
function was previously defined inGenerativeModelVertexAITests.swift
and is now available inGenerativeModelTestUtil.swift
. Ensure that all call sites are updated to use the utility function to avoid future duplication. - Incomplete test coverage for error cases: While the tests cover many scenarios, consider adding more specific tests for different error conditions, especially around safety ratings and prompt blocking, to ensure comprehensive coverage.
Merge Readiness
The pull request is almost ready for merging. Addressing the duplicated functions and ensuring consistent use of utility functions will improve maintainability. While I am unable to directly approve this pull request, I recommend that the author address the comments before merging, and that other reviewers also review and approve this code before merging.
Split
GenerativeModelTests
intoGenerativeModelGoogleAITests
andGenerativeModelVertexAITests
to test against the two sets of mock responses for the Google AI and Vertex AI backends.#no-changelog