Skip to content

[Firebase AI] Add GenerativeModel tests using Dev API mock responses #14816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025

Conversation

andrewheard
Copy link
Contributor

Split GenerativeModelTests into GenerativeModelGoogleAITests and GenerativeModelVertexAITests to test against the two sets of mock responses for the Google AI and Vertex AI backends.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new tests for GenerativeModel using mock responses for both Google AI and Vertex AI backends. The code is well-structured and the tests cover various success and failure scenarios. However, there are a few areas that could be improved for better maintainability and clarity.

Summary of Findings

  • Duplicated httpRequestHandler and nonHTTPRequestHandler functions: The httpRequestHandler and nonHTTPRequestHandler functions are duplicated in GenerativeModelVertexAITests.swift and were moved to GenerativeModelTestUtil.swift. Ensure that all call sites are updated to use the utility functions to avoid future duplication.
  • Inconsistent use of GenerativeModelTestUtil.testFirebaseInfo(): The testFirebaseInfo() function was previously defined in GenerativeModelVertexAITests.swift and is now available in GenerativeModelTestUtil.swift. Ensure that all call sites are updated to use the utility function to avoid future duplication.
  • Incomplete test coverage for error cases: While the tests cover many scenarios, consider adding more specific tests for different error conditions, especially around safety ratings and prompt blocking, to ensure comprehensive coverage.

Merge Readiness

The pull request is almost ready for merging. Addressing the duplicated functions and ensuring consistent use of utility functions will improve maintainability. While I am unable to directly approve this pull request, I recommend that the author address the comments before merging, and that other reviewers also review and approve this code before merging.

@andrewheard andrewheard marked this pull request as ready for review May 5, 2025 19:34
@andrewheard andrewheard requested a review from paulb777 May 5, 2025 19:34
@andrewheard andrewheard merged commit 1a5a42f into main May 5, 2025
74 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-golden-tests branch May 5, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants