Bind rmqID instead of using stringWithFormat.

[leojaygoogle]

When populating SQL queries to find messages by ID, stringWithFormat is currently being used.

firebase-ios-sdk/FirebaseMessaging/Sources/FIRMessagingRmqManager.m

Lines 280 to 287 in 1deb75c

	NSString *queryFormat = @"SELECT %@ FROM %@ WHERE %@ = '%@'";
	NSString *query =
	[NSString stringWithFormat:queryFormat,
	kSyncMessagesColumns, // SELECT (rmq_id, expiration_ts,
	// apns_recv, mcs_recv)
	kTableSyncMessages, // FROM sync_rmq
	kRmqIdColumn, // WHERE rmq_id
	rmqID];

This is a potential SQL injection vulnerability. Even though it's very unlikely to be exploited since the rmqID is not user input, but a Google generated ID, we should follow best practices and use sqlite3_bind_text to bind the value instead.

This PR introduces no behavioral changes. It just changes how the SQL query is populated.
#14846.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

[ncooke3]

Nice!

[ncooke3]

Could you also please add a changelog entry that references the original issue?

[ncooke3]

Thanks!