-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Firebase AI] Add support for configuring a thinking budget #14909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds support for configuring a thinking budget in Gemini 2.5 series models. The changes include updates to data structures for request and response, as well as comprehensive integration tests. The new ThinkingConfig
is well-defined. Minor improvements suggested involve adding documentation comments for new public properties in GenerateContentResponse
and GenerationConfig
to enhance SDK usability.
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
Added support for configuring the
thinkingBudget
in Gemini 2.5 series models.