Skip to content

[Firebase AI] Add support for configuring a thinking budget #14909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 16, 2025

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented May 29, 2025

Added support for configuring the thinkingBudget in Gemini 2.5 series models.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard added this to the 11.15.0 - M166 milestone Jun 16, 2025
@firebase firebase deleted a comment from google-oss-bot Jun 16, 2025
@andrewheard andrewheard marked this pull request as ready for review June 16, 2025 17:05
@google-oss-bot
Copy link

1 Warning
⚠️ New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

@andrewheard andrewheard requested review from paulb777 and daymxn June 16, 2025 17:06
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for configuring a thinking budget in Gemini 2.5 series models. The changes include updates to data structures for request and response, as well as comprehensive integration tests. The new ThinkingConfig is well-defined. Minor improvements suggested involve adding documentation comments for new public properties in GenerateContentResponse and GenerationConfig to enhance SDK usability.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@andrewheard andrewheard merged commit a14936c into main Jun 16, 2025
60 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-thinkingbudget branch June 16, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants