Skip to content

[DynamicLinks] Remove library and corresponding infra #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ body:
- Crashlytics
- Database
- Data Connect
- DynamicLinks
- Firestore
- Functions
- In-App Messaging
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/archiving.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
# These need to be on a single line or else the formatting won't validate.
pod: ["FirebaseAppDistribution", "FirebaseDynamicLinks", "FirebaseInAppMessaging", "FirebasePerformance"]
pod: ["FirebaseAppDistribution", "FirebaseInAppMessaging", "FirebasePerformance"]
steps:
- uses: actions/checkout@v4
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand Down
61 changes: 0 additions & 61 deletions .github/workflows/dynamiclinks.yml

This file was deleted.

26 changes: 1 addition & 25 deletions .github/workflows/health-metrics-presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
auth_run_job: ${{ steps.check_files.outputs.auth_run_job }}
crashlytics_run_job: ${{ steps.check_files.outputs.crashlytics_run_job }}
database_run_job: ${{ steps.check_files.outputs.database_run_job }}
dynamiclinks_run_job: ${{ steps.check_files.outputs.dynamiclinks_run_job }}
firestore_run_job: ${{ steps.check_files.outputs.firestore_run_job }}
functions_run_job: ${{ steps.check_files.outputs.functions_run_job }}
inappmessaging_run_job: ${{ steps.check_files.outputs.inappmessaging_run_job }}
Expand Down Expand Up @@ -126,29 +125,6 @@
name: codecoverage
path: /Users/runner/*.xcresult

pod-lib-lint-dynamiclinks:
needs: check
# Don't run on private repo unless it is a PR.
if: always() && github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.dynamiclinks_run_job == 'true'|| github.event.pull_request.merged)
runs-on: macos-14
strategy:
matrix:
target: [iOS]
steps:
- uses: actions/checkout@v4
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
with:
cache_key: ${{ matrix.os }}
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: Build and test
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDynamicLinks --platform=${{ matrix.target }}
- uses: actions/upload-artifact@v4
with:
name: codecoverage
path: /Users/runner/*.xcresult

pod-lib-lint-firestore:
needs: check
# Don't run on private repo unless it is a PR.
Expand Down Expand Up @@ -317,71 +293,71 @@
path: /Users/runner/*.xcresult

create_report:
needs: [check, pod-lib-lint-abtesting, pod-lib-lint-auth, pod-lib-lint-database, pod-lib-lint-dynamiclinks, pod-lib-lint-firestore, pod-lib-lint-functions, pod-lib-lint-inappmessaging, pod-lib-lint-messaging, pod-lib-lint-performance, pod-lib-lint-remoteconfig, pod-lib-lint-storage]
needs: [check, pod-lib-lint-abtesting, pod-lib-lint-auth, pod-lib-lint-database, pod-lib-lint-firestore, pod-lib-lint-functions, pod-lib-lint-inappmessaging, pod-lib-lint-messaging, pod-lib-lint-performance, pod-lib-lint-remoteconfig, pod-lib-lint-storage]
if: always()
runs-on: macos-14
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Access to Metrics Service
if: github.event.pull_request.head.repo.full_name == github.repository && (github.event.action != 'closed' || github.event.pull_request.merged)
run: |
# Install gcloud sdk
curl https://sdk.cloud.google.com > install.sh
bash install.sh --disable-prompts
echo "${HOME}/google-cloud-sdk/bin/" >> $GITHUB_PATH
export PATH="${HOME}/google-cloud-sdk/bin/:${PATH}"

# Activate the service account for Metrics Service.
scripts/decrypt_gha_secret.sh scripts/gha-encrypted/metrics_service_access.json.gpg \
metrics-access.json "${{ env.METRICS_SERVICE_SECRET }}"
gcloud auth activate-service-account --key-file metrics-access.json
- uses: actions/download-artifact@v4.1.7
id: download
with:
path: /Users/runner/test
- name: Compare Diff and Post a Report
if: github.event.pull_request.merged != true && github.event.action != 'closed' && github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.base.ref == 'main'
env:
base_commit: ${{ needs.check.outputs.target_branch_head }}
run: |
# Get Head commit of the branch, instead of a merge commit created by actions/checkout.
if [ -d "${{steps.download.outputs.download-path}}" ]; then
cd scripts/health_metrics/generate_code_coverage_report
swift run CoverageReportGenerator --presubmit "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --pull-request-num ${{github.event.pull_request.number}} --base-commit "$base_commit"
fi
# Will reactivate the job after the issue #8305 is resovled.
# - name: Incremental Code Coverage
# if: github.event.pull_request.merged != true && github.event.action != 'closed'
# env:
# base_commit: ${{ needs.check.outputs.base_commit }}
# run: |
# # Get Head commit of the branch, instead of a merge commit created by actions/checkout.
# GITHUB_SHA=$(cat $GITHUB_EVENT_PATH | jq -r .pull_request.head.sha)
# # Get a JSON of `git diff` from the base commit.
# git diff -U0 ${base_commit} "${GITHUB_SHA}" | scripts/health_metrics/git_diff_to_json.sh > scripts/health_metrics/generate_code_coverage_report/git_diff.json
# cat "scripts/health_metrics/generate_code_coverage_report/git_diff.json"
# if [ -d "${{steps.download.outputs.download-path}}" ]; then
# # Create an uncovered_file_lines.json including code lines not covered by tests.
# cd scripts/health_metrics/generate_code_coverage_report
# swift run IncrementalCoverageReportGenerator --changed-files "git_diff.json" --file-archive-root-path "${GITHUB_WORKSPACE}" --xcresult-dir "${{steps.download.outputs.download-path}}" --uncovered-line-file-json "uncovered_file_lines.json"
# # Post uncovered lines to PRs.
# pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
# cd ..
# bundle install
# INPUT_ACCESS_TOKEN=${{ secrets.GITHUB_TOKEN }} \
# GITHUB_REPOSITORY="${GITHUB_REPOSITORY}" \
# UNCOVERED_LINE_FILE="generate_code_coverage_report/uncovered_file_lines.json" \
# TESTING_COMMIT="${GITHUB_SHA}" \
# PULL_REQUEST="${pull_number}" \
# bundle exec ruby post_incremental_coverage_in_pr.rb
# fi
- name: Update New Coverage Data
if: github.event.pull_request.merged && github.event.pull_request.head.repo.full_name == github.repository
run: |
if [ -d "${{steps.download.outputs.download-path}}" ]; then
cd scripts/health_metrics/generate_code_coverage_report
swift run CoverageReportGenerator --merge "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --source-branch "${{ github.base_ref }}"
fi

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
2 changes: 0 additions & 2 deletions .github/workflows/zip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ jobs:
- name: Setup Swift Quickstart
run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FBSDKLoginKit FBSDKCoreKit FBSDKCoreKit_Basics FBAEMKit" scripts/setup_quickstart_framework.sh \
"${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseDynamicLinks/* \
"${HOME}"/ios_frameworks/Firebase/GoogleSignIn/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
Expand Down Expand Up @@ -508,7 +507,6 @@ jobs:
- uses: actions/checkout@v4
- name: Setup quickstart
run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \
"${HOME}"/ios_frameworks/Firebase/FirebaseDynamicLinks/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
- name: Xcode
Expand Down
1 change: 0 additions & 1 deletion Carthage.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAppDistributionBi
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAuthBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseCrashlyticsBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseDatabaseBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseDynamicLinksBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseFirestoreBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseFunctionsBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseGoogleSignInBinary.json"
Expand Down
1 change: 0 additions & 1 deletion CoreOnly/NOTICES
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ FirebaseAuthInterop
FirebaseCore
FirebaseCoreExtension
FirebaseCoreInternal
FirebaseDynamicLinks
FirebaseFunctions
FirebaseInAppMessaging
FirebaseInstallations
Expand Down
4 changes: 0 additions & 4 deletions CoreOnly/Sources/Firebase.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@
#import <FirebaseDatabase/FirebaseDatabase.h>
#endif

#if __has_include(<FirebaseDynamicLinks/FirebaseDynamicLinks.h>)
#import <FirebaseDynamicLinks/FirebaseDynamicLinks.h>
#endif

#if __has_include(<FirebaseFirestore/FirebaseFirestore.h>)
#import <FirebaseFirestore/FirebaseFirestore.h>
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
// Uncomment next line if ABTesting gets added to Firebase.h.
// class ABTestingExists : LifecycleEvents {}
class DatabaseExists: Database {}
class DynamicLinksExists: DynamicLinks {}
class FirestoreExists: Firestore {}
class FunctionsExists: Functions {}

Check warning on line 29 in CoreOnly/Tests/FirebasePodTest/FirebasePodTest/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / installation-test

class 'FunctionsExists' must restate inherited '@unchecked Sendable' conformance

Check warning on line 29 in CoreOnly/Tests/FirebasePodTest/FirebasePodTest/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / installation-test

class 'FunctionsExists' must restate inherited '@unchecked Sendable' conformance
class InAppMessagingExists: InAppMessaging {}
class InAppMessagingDisplayExists: InAppMessagingDisplay { // protocol instead of interface
func displayMessage(_ messageForDisplay: InAppMessagingDisplayMessage,
Expand Down
1 change: 0 additions & 1 deletion CoreOnly/Tests/FirebasePodTest/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ target 'FirebasePodTest' do
pod 'FirebaseCore', :path => '../../../'
pod 'FirebaseCrashlytics', :path => '../../../'
pod 'FirebaseDatabase', :path => '../../../'
pod 'FirebaseDynamicLinks', :path => '../../../'
pod 'FirebaseFirestore', :path => '../../../'
pod 'FirebaseFirestoreInternal', :path => '../../../'
pod 'FirebaseFunctions', :path => '../../../'
Expand Down
5 changes: 0 additions & 5 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def labelsForModifiedFiles()
labels.push("api: core") if @has_core_changes
labels.push("api: crashlytics") if @has_crashlytics_changes
labels.push("api: database") if @has_database_changes
labels.push("api: dynamiclinks") if @has_dynamiclinks_changes
labels.push("api: firebaseai") if @has_firebaseai_changes
labels.push("api: firestore") if @has_firestore_changes
labels.push("api: functions") if @has_functions_changes
Expand Down Expand Up @@ -93,7 +92,6 @@ has_license_changes = didModify(["LICENSE"])
"Core",
"Crashlytics",
"Database",
"DynamicLinks",
"FirebaseAI",
"Firestore",
"Functions",
Expand Down Expand Up @@ -132,8 +130,6 @@ has_license_changes = didModify(["LICENSE"])
@has_crashlytics_api_changes = hasChangesIn("Crashlytics/Crashlytics/Public/")
@has_database_changes = hasChangesIn("FirebaseDatabase")
@has_database_api_changes = hasChangesIn("FirebaseDatabase/Sources/Public/")
@has_dynamiclinks_changes = hasChangesIn("FirebaseDynamicLinks")
@has_dynamiclinks_api_changes = hasChangesIn("FirebaseDynamicLinks/Sources/Public/")
@has_firebaseai_changes = hasChangesIn([
"FirebaseAI",
"FirebaseVertexAI"
Expand Down Expand Up @@ -168,7 +164,6 @@ has_license_changes = didModify(["LICENSE"])
@has_core_api_changes ||
@has_crashlytics_api_changes ||
@has_database_api_changes ||
@has_dynamiclinks_api_changes ||
@has_firestore_api_changes ||
@has_functions_api_changes ||
@has_inappmessaging_api_changes ||
Expand Down
6 changes: 0 additions & 6 deletions Firebase.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@ Simplify your app development, grow your user base, and monetize more effectivel
ss.watchos.deployment_target = '7.0'
end

s.subspec 'DynamicLinks' do |ss|
ss.dependency 'Firebase/CoreOnly'
ss.ios.dependency 'FirebaseDynamicLinks', '~> 11.15.0'
ss.ios.deployment_target = '13.0'
end

s.subspec 'Firestore' do |ss|
ss.dependency 'Firebase/CoreOnly'
ss.dependency 'FirebaseFirestore', '~> 11.15.0'
Expand Down
4 changes: 4 additions & 0 deletions FirebaseCore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Unreleased
- [removed] **Breaking change**: FirebaseDynamicLinks has been removed. See
https://firebase.google.com/support/dynamic-links-faq for more info.

# Firebase 11.15.0
- [fixed] Remove c99 as the required C language standard. (#14950)

# Firebase 11.12.0
Expand Down
60 changes: 0 additions & 60 deletions FirebaseDynamicLinks.podspec

This file was deleted.

4 changes: 4 additions & 0 deletions FirebaseDynamicLinks/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 12.0.0
- [removed] **Breaking change**: FirebaseDynamicLinks has been removed. See
https://firebase.google.com/support/dynamic-links-faq for more info.

# 11.8.0
- [deprecated] The `FirebaseDynamicLinks` CocoaPod is deprecated. For information about timelines and alternatives, see the [Dynamic Links deprecation FAQ](https://firebase.google.com/support/dynamic-links-faq).

Expand Down
40 changes: 0 additions & 40 deletions FirebaseDynamicLinks/README.md

This file was deleted.

Loading
Loading