Skip to content

Exchange token tests #14984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: exchangeToken-auth
Choose a base branch
from
Draft

Conversation

srushtisv
Copy link
Contributor

Description

This PR introduces unit tests for the ExchangeTokenRequest.swift file, which was added to support the Bring Your Own CIAM (BYO-CIAM) feature. These tests verify that the request to the regionalized identityplatform.googleapis.com service for exchanging OIDC tokens is constructed correctly.

Tests Added:

  • Verification of the full URL for different regions, including the special prod-global case, for both production and staging (useStaging) environments. This includes the host, the /v2beta/ API version path, project, location, tenant, and IDP config segments.
  • Validation of the unencodedHTTPRequestBody to ensure it contains the id_token.

To ensure the reliability and correctness of the network requests made during the OIDC token exchange flow, which is critical for the BYO-CIAM functionality.
This PR only adds test code and does not affect the SDK's public API or runtime behavior.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@srushtisv srushtisv changed the base branch from main to exchangeToken-auth June 14, 2025 21:06
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants