Skip to content

fix(ci): Resolve syntax error in zip.yml #15425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 22, 2025
Merged

fix(ci): Resolve syntax error in zip.yml #15425

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d69c3db
dnm: Test nc/quickstarts branch
ncooke3 Oct 17, 2025
adf0774
fix syntax
ncooke3 Oct 17, 2025
86123e8
Some fixes
ncooke3 Oct 17, 2025
3baf491
progress
ncooke3 Oct 17, 2025
4eb96d2
address comment manually
ncooke3 Oct 17, 2025
d683df8
remove comms
ncooke3 Oct 17, 2025
844c0f7
database
ncooke3 Oct 20, 2025
ce05f3c
analytics fix
ncooke3 Oct 22, 2025
48df192
Apply suggestion from @ncooke3
ncooke3 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/inappmessaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,6 @@ jobs:
setup_command: scripts/setup_quickstart_spm.sh inappmessaging
plist_src_path: scripts/gha-encrypted/qs-inappmessaging.plist.gpg
plist_dst_path: quickstart-ios/inappmessaging/GoogleService-Info.plist
run_tests: false
secrets:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:

env:
FIREBASE_CI: true
FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: true

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
Expand Down Expand Up @@ -72,7 +73,7 @@ jobs:
- product: Messaging
run_tests: false
- product: InAppMessaging
run_tests: true
run_tests: false
- product: Firestore
run_tests: false
- product: Database
Expand All @@ -82,7 +83,7 @@ jobs:
- product: Crashlytics
run_tests: true
- product: ABTesting
run_tests: true
run_tests: false
name: 'quickstart (release, ${{ matrix.product }}, run_tests: ${{ matrix.run_tests }})'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
Expand Down
17 changes: 2 additions & 15 deletions .github/workflows/zip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
# zip from the current commit (HEAD).
name: zip

# TODO(ncooke3): Add FirebaseAI test.

permissions:
actions: read
contents: read
Expand Down Expand Up @@ -247,13 +245,6 @@ jobs:
quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret"
- name: Test Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
- name: Remove data before upload
if: always()
run: scripts/remove_data.sh abtesting
# - uses: actions/upload-artifact@v4
# if: failure()
# with:
# name: quickstart_artifacts_abtesting
- uses: actions/upload-artifact@v4
if: failure()
with:
Expand All @@ -271,7 +262,7 @@ jobs:
strategy:
matrix:
os: [macos-15]
artifact: [Firebase-actions-dir] , Firebase-actions-dir-dynamic]
artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic]
include:
- os: macos-15
xcode: Xcode_16.4
Expand Down Expand Up @@ -473,7 +464,7 @@ jobs:
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \
quickstart-ios/database/GoogleService-Info.plist "$plist_secret"
- name: Test Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
- uses: actions/upload-artifact@v4
if: failure()
with:
Expand Down Expand Up @@ -579,8 +570,6 @@ jobs:
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \
quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret"
- name: Test Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
- name: Test Swift Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
- uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -633,8 +622,6 @@ jobs:
quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret"
- name: Test Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
- name: Test Swift Quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
- uses: actions/upload-artifact@v4
if: failure()
with:
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# To update, change version below, run bundle install, test,
#
Copy link
Member Author

@ncooke3 ncooke3 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#

# commit Gemfile and Gemfile.lock.
source 'https://rubygems.org'

Expand Down
Loading