Skip to content

Commit 13e6cce

Browse files
authored
Feat/google3 typings support (#9085)
1 parent 7fb64dd commit 13e6cce

File tree

5 files changed

+39
-2
lines changed

5 files changed

+39
-2
lines changed

.changeset/brave-boats-arrive.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@firebase/remote-config': patch
3+
'@firebase/analytics': patch
4+
'firebase': patch
5+
---
6+
7+
Add rollup config to generate modular typings for google3

packages/analytics/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"devDependencies": {
5050
"@firebase/app": "0.13.1",
5151
"rollup": "2.79.2",
52+
"rollup-plugin-dts": "5.3.1",
5253
"@rollup/plugin-commonjs": "21.1.0",
5354
"@rollup/plugin-json": "6.1.0",
5455
"@rollup/plugin-node-resolve": "16.0.0",

packages/analytics/rollup.config.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import json from '@rollup/plugin-json';
1919
import typescriptPlugin from 'rollup-plugin-typescript2';
2020
import replace from 'rollup-plugin-replace';
2121
import typescript from 'typescript';
22+
import dts from 'rollup-plugin-dts';
2223
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2324
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2425
import pkg from './package.json';
@@ -77,4 +78,17 @@ const cjsBuilds = [
7778
}
7879
];
7980

80-
export default [...esmBuilds, ...cjsBuilds];
81+
const google3TypingsBuild = {
82+
input: 'dist/src/index.d.ts',
83+
output: {
84+
file: 'dist/src/global_index.d.ts',
85+
format: 'es'
86+
},
87+
plugins: [
88+
dts({
89+
respectExternal: true
90+
})
91+
]
92+
};
93+
94+
export default [...esmBuilds, ...cjsBuilds, google3TypingsBuild];

packages/remote-config/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
"devDependencies": {
5151
"@firebase/app": "0.13.1",
5252
"rollup": "2.79.2",
53+
"rollup-plugin-dts": "5.3.1",
5354
"rollup-plugin-typescript2": "0.36.0",
5455
"typescript": "5.5.4"
5556
},

packages/remote-config/rollup.config.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import json from '@rollup/plugin-json'; // Enables package.json import in TypeSc
1919
import typescriptPlugin from 'rollup-plugin-typescript2';
2020
import replace from 'rollup-plugin-replace';
2121
import typescript from 'typescript';
22+
import dts from 'rollup-plugin-dts';
2223
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2324
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2425
import pkg from './package.json';
@@ -70,4 +71,17 @@ const cjsBuild = {
7071
]
7172
};
7273

73-
export default [esmBuild, cjsBuild];
74+
const google3TypingsBuild = {
75+
input: 'dist/src/index.d.ts',
76+
output: {
77+
file: 'dist/src/global_index.d.ts',
78+
format: 'es'
79+
},
80+
plugins: [
81+
dts({
82+
respectExternal: true
83+
})
84+
]
85+
};
86+
87+
export default [esmBuild, cjsBuild, google3TypingsBuild];

0 commit comments

Comments
 (0)