fix lint errors

Author: dconeybe

packages/firestore/src/core/firestore_client.ts

@@ -231,7 +231,21 @@ export async function setOfflineComponentProvider(
   });
 
   offlineComponentProvider.persistence.setDatabaseDeletedListener(() => {
-    client.terminate();
+    logWarn('Terminating Firestore due to IndexedDb database deletion');
+    client
+      .terminate()
+      .then(() => {
+        logDebug(
+          'Terminating Firestore due to IndexedDb database deletion ' +
+            'completed successfully'
+        );
+      })
+      .catch(error => {
+        logWarn(
+          'Terminating Firestore due to IndexedDb database deletion failed',
+          error
+        );
+      });
   });
 
   client._offlineComponents = offlineComponentProvider;

packages/firestore/src/local/indexeddb_persistence.ts

@@ -31,7 +31,6 @@ import { BundleCache } from './bundle_cache';
 import { DocumentOverlayCache } from './document_overlay_cache';
 import { GlobalsCache } from './globals_cache';
 import { IndexManager } from './index_manager';
-import { DatabaseDeletedListener } from './persistence';
 import { IndexedDbBundleCache } from './indexeddb_bundle_cache';
 import { IndexedDbDocumentOverlayCache } from './indexeddb_document_overlay_cache';
 import { IndexedDbGlobalsCache } from './indexeddb_globals_cache';
@@ -59,7 +58,11 @@ import { IndexedDbTargetCache } from './indexeddb_target_cache';
 import { getStore, IndexedDbTransaction } from './indexeddb_transaction';
 import { LocalSerializer } from './local_serializer';
 import { LruParams } from './lru_garbage_collector';
-import { Persistence, PrimaryStateListener } from './persistence';
+import {
+  DatabaseDeletedListener,
+  Persistence,
+  PrimaryStateListener
+} from './persistence';
 import { PersistencePromise } from './persistence_promise';
 import {
   PersistenceTransaction,

packages/firestore/src/local/simple_db.ts

@@ -19,11 +19,11 @@ import { getGlobal, getUA, isIndexedDBAvailable } from '@firebase/util';
 
 import { debugAssert } from '../util/assert';
 import { Code, FirestoreError } from '../util/error';
-import { logDebug, logError } from '../util/log';
+import { logDebug, logError, logWarn } from '../util/log';
 import { Deferred } from '../util/promise';
 
-import { PersistencePromise } from './persistence_promise';
 import { DatabaseDeletedListener } from './persistence';
+import { PersistencePromise } from './persistence_promise';
 
 // References to `indexedDB` are guarded by SimpleDb.isAvailable() and getGlobal()
 /* eslint-disable no-restricted-globals */
@@ -399,6 +399,10 @@ export class SimpleDb {
         // Notify the listener if another tab attempted to delete the IndexedDb
         // database, such as by calling clearIndexedDbPersistence().
         if (event.newVersion === null) {
+          logWarn(
+            `Received "versionchange" event with newVersion===null; ` +
+              'notifying the registered DatabaseDeletedListener, if any'
+          );
           this.databaseDeletedListener?.();
         }
       },

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -366,7 +366,13 @@ abstract class TestRunner {
       triggerRemoteStoreUnlisten.bind(null, this.syncEngine);
 
     this.persistence.setDatabaseDeletedListener(() => {
-      this.shutdown();
+      this.shutdown().catch(error => {
+        console.warn(
+          'WARNING: this.shutdown() failed in callback ' +
+            'specified to persistence.setDatabaseDeletedListener',
+          error
+        );
+      });
     });
 
     this.started = true;