Added ability to retry unauthorized requests #8351

maneesht · 2024-07-03T23:08:24Z

Made sure that any time the server responds with unauthenticated, we do a forceToken refresh and retry as long as the token is new.

changeset-bot · 2024-07-03T23:08:27Z

⚠️ No Changeset found

Latest commit: 20ff671

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-07-03T23:24:26Z

Size Report ¹

Affected Products

@firebase/data-connect
Type Base (ebbb191) Merge (a6d920f) Diff
browser 16.7 kB 17.3 kB +571 B (+3.4%)
esm5 18.7 kB 19.4 kB +733 B (+3.9%)
main 20.8 kB 21.5 kB +733 B (+3.5%)
module 16.7 kB 17.3 kB +571 B (+3.4%)
firebase
Type Base (ebbb191) Merge (a6d920f) Diff
firebase-data-connect.js 14.4 kB 14.8 kB +366 B (+2.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/laCQWAmNGQ.html

google-oss-bot · 2024-07-03T23:36:26Z

Size Analysis Report ¹

Affected Products

@firebase/data-connect
- DataConnect
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.58 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.61 kB 10.0 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- FirebaseAuthProvider
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.59 kB 9.99 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- MUTATION_STR
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.60 kB 10.0 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- MutationManager
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.59 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- QUERY_STR
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.58 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- SOURCE_CACHE
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.58 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- SOURCE_SERVER
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.59 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- connectDataConnectEmulator
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.67 kB 10.1 kB +397 B (+4.1%)
  size-with-ext-deps 27.7 kB 28.1 kB +401 B (+1.4%)
- executeMutation
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.66 kB 10.1 kB +397 B (+4.1%)
  size-with-ext-deps 27.7 kB 28.1 kB +401 B (+1.4%)
- executeQuery
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.65 kB 10.0 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- getDataConnect
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 10.3 kB 10.7 kB +397 B (+3.9%)
  size-with-ext-deps 35.4 kB 35.8 kB +401 B (+1.1%)
- mutationRef
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.70 kB 10.1 kB +397 B (+4.1%)
  size-with-ext-deps 27.7 kB 28.1 kB +401 B (+1.4%)
- parseOptions
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.58 kB 9.98 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- queryRef
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.70 kB 10.1 kB +397 B (+4.1%)
  size-with-ext-deps 27.7 kB 28.1 kB +401 B (+1.4%)
- setLogLevel
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.61 kB 10.0 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- subscribe
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 10.8 kB 11.2 kB +397 B (+3.7%)
  size-with-ext-deps 35.9 kB 36.3 kB +401 B (+1.1%)
- terminate
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.61 kB 10.0 kB +397 B (+4.1%)
  size-with-ext-deps 27.6 kB 28.0 kB +401 B (+1.5%)
- toQueryRef
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 10.5 kB 10.9 kB +397 B (+3.8%)
  size-with-ext-deps 35.6 kB 36.0 kB +401 B (+1.1%)
- validateDCOptions
  Size
  Type Base (ebbb191) Merge (a6d920f) Diff
  size 9.82 kB 10.2 kB +397 B (+4.0%)
  size-with-ext-deps 27.8 kB 28.2 kB +401 B (+1.4%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xuNrRI1gHr.html

dconeybe · 2024-07-19T15:57:30Z

packages/data-connect/src/network/transport/rest.ts

@@ -34,6 +34,7 @@ export class RESTTransport implements DataConnectTransport {
  private _serviceName: string;
  private _accessToken: string | null = null;
  private _authInitialized = false;
+  private _lastToken: string | null = null;


I just realized I forgot to check for a changed token in Android! I'll go ahead and implement that.

…auth-retry

Added ability to retry unauthorized requests

e8729b0

maneesht requested a review from a team as a code owner July 3, 2024 23:08

maneesht requested review from dconeybe and removed request for a team July 3, 2024 23:08

maneesht added 3 commits July 3, 2024 16:09

Undid comment change

e0a9211

Removed emulator.json file

fa933a3

Removed todo

b39b8cc

dconeybe reviewed Jul 19, 2024

View reviewed changes

dconeybe approved these changes Jul 19, 2024

View reviewed changes

dconeybe assigned maneesht Jul 19, 2024

maneesht and others added 2 commits July 19, 2024 09:51

Merge remote-tracking branch 'public/dataconnect' into mtewani/allow-…

f8bad0b

…auth-retry

Update API reports

20ff671

maneesht merged commit 7cc2b9c into dataconnect Jul 19, 2024
1 check passed

maneesht deleted the mtewani/allow-auth-retry branch July 19, 2024 17:33

firebase locked and limited conversation to collaborators Aug 19, 2024

Added ability to retry unauthorized requests #8351

Added ability to retry unauthorized requests #8351

Uh oh!

Conversation

maneesht commented Jul 3, 2024

Uh oh!

changeset-bot bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/data-connect

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/data-connect

DataConnect

FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR

FirebaseAuthProvider

MUTATION_STR

MutationManager

QUERY_STR

SOURCE_CACHE

SOURCE_SERVER

connectDataConnectEmulator

executeMutation

executeQuery

getDataConnect

mutationRef

parseOptions

queryRef

setLogLevel

subscribe

terminate

toQueryRef

validateDCOptions

Test Logs

Uh oh!

dconeybe Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jul 3, 2024 •

edited

Loading

google-oss-bot commented Jul 3, 2024 •

edited

Loading

Size Report ¹

`@firebase/data-connect`

`firebase`

google-oss-bot commented Jul 3, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/data-connect`

`DataConnect`

`FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR`

`FirebaseAuthProvider`

`MUTATION_STR`

`MutationManager`

`QUERY_STR`

`SOURCE_CACHE`

`SOURCE_SERVER`

`connectDataConnectEmulator`

`executeMutation`

`executeQuery`

`getDataConnect`

`mutationRef`

`parseOptions`

`queryRef`

`setLogLevel`

`subscribe`

`terminate`

`toQueryRef`

`validateDCOptions`