Maintain persistence for firebaseToken in AuthImpl object #9119
+101
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
NhienLam and
a team
as code owners
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
pashanka
reviewed
Jun 25, 2025
| if (firebaseToken) { | ||
| await this.assertedPersistence.setFirebaseToken(firebaseToken); | ||
| } else { | ||
| await this.assertedPersistence.removeFirebaseToken(); |
There was a problem hiding this comment.
You will have to do same for signOut as well right?
There was a problem hiding this comment.
Correct. I plan to create a separate CL for signOut logic. Please let me know if you see any concerns.
NhienLam
reviewed
Jun 30, 2025
| @@ -280,6 +280,12 @@ export interface Auth { | |||
| callback: (user: User | null) => void | Promise<void>, | |||
| onAbort?: () => void | |||
| ): Unsubscribe; | |||
|
|
|||
| onFirebaseTokenChanged( | |||
There was a problem hiding this comment.
q: When do we call onFirebaseTokenChanged?
- Please add jsdoc
- Do we need to implement a onFirebaseTokenChanged function in packages/auth/src/core/index.ts ?
There was a problem hiding this comment.
Hey, I onFirebaseTokenChanged is a callback method that is triggered when firebase token is updated i.e. during the following scenarios -
- On App initialization when FirebaseToken is fetched from the persistence.
- When a getToken method is triggered and the token is expired. In this case the firebaseToken is updated to
null.
The callback method was initially not planned. I had a discussion with pavanshankar@ and we decided on decoupling the persistence logic with the callback method.
Created a PR - #9138 for persisting the firebaseToken for BYO-CIAM.
sam-gc
reviewed
Jun 30, 2025
| @@ -280,6 +280,12 @@ export interface Auth { | |||
| callback: (user: User | null) => void | Promise<void>, | |||
| onAbort?: () => void | |||
| ): Unsubscribe; | |||
|
|
|||
| onFirebaseTokenChanged( | |||
There was a problem hiding this comment.
Related: this method was not part of the API review. I'm concerned that onFirebaseTokenChanged (and the concept of a FirebaseToken) is very generic sounding. I'm worried it'll confuse users.
There was a problem hiding this comment.
Agreed.
The onFirebaseTokenChanged callback method was initially not planned during the API Review. Had a discussion with pavanshankar@ offline. Currently decoupling the callback from the persistence changes.
Created a PR - #9138 for persisting the firebaseToken for BYO-CIAM.
There was a problem hiding this comment.
We should go through another API review process surfacing this. "firebaseToken" is a really generic name -- "Firebase" is a huge suite of products that has many different types of tokens. Any and every change to the public API surface needs to go through review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
Testing