Skip to content

Increase unit test coverage for saml.ts to 100% #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Increase unit test coverage for saml.ts to 100% #9131

merged 2 commits into from
Jul 3, 2025

Conversation

mansisampat
Copy link
Contributor

Discussion

Testing

  • Unit test passing locally.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b32283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 27, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (3d44792) and merge commit (663799c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jmcQeoHJuZ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 27, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (3d44792) and merge commit (663799c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xUAuZ9xH1Z.html

Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jul 1, 2025
View reviewed changes
packages/auth/src/core/providers/saml.test.ts

it('credentialFromJSON returns SAML credential from valid object', () => {
const json = {
providerId: 'saml.provider',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible providerId and signInMethod are different? maybe we should use a different string for assertion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Liubin,

We have a validation in the SamlAuthCredential.fromJson method to validate that providerId === signInMethod - https://github.com/firebase/firebase-js-sdk/blob/main/packages/auth/src/core/credentials/saml.ts#L95

Hence using the same string.

@mansisampat mansisampat merged commit ab5c2a0 into main Jul 3, 2025
49 checks passed
@mansisampat mansisampat deleted the auth-test-saml branch July 3, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@NhienLam NhienLam NhienLam approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mansisampat @google-oss-bot @Xiaoshouzi-gh @NhienLam