Create a command to export Firebase Functions' IaC#10034
Create a command to export Firebase Functions' IaC#10034
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an experimental feature to export Firebase Cloud Functions' Infrastructure as Code (IaC). The primary goal is to provide a mechanism for managing functions through external tools like Terraform or Application Design Center by generating a manifest of the functions' configuration. This initial checkpoint focuses on establishing the command-line interface and the foundational logic for manifest generation, with support for different output formats planned for future iterations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an experimental feature to export Firebase Functions' Infrastructure as Code (IaC). The changes include a new command functions:export, its integration into the CLI, and the underlying logic to generate the manifest. The implementation correctly handles different output formats and codebase selections. A minor improvement opportunity was identified regarding the use of console.log for user-facing output, which violates the established style guide.
| for (const [file, contents] of Object.entries(manifest)) { | ||
| console.log(`Manifest file: ${clc.bold(file)}`); | ||
| console.log(contents); |
There was a problem hiding this comment.
The repository's style guide (line 29) explicitly states to "Use the central logger (src/logger.ts); never use console.log() for user-facing output." Please replace console.log with logger.info or logger.debug as appropriate for user-facing output.
For example, logger.info(Manifest file: ${clc.bold(file)}); and logger.info(contents);
logger.info(`Manifest file: ${clc.bold(file)}`);
logger.info(contents);|
My update changes so much that I might as well create a fresh review. |
Checkpointing a work in progress for an experimental feature to export Functions' IaC. This can be used to eventually support management via Terraform or the Application Design Center.