Skip to content

Create a command to export Firebase Functions' IaC#10034

Closed
inlined wants to merge 4 commits intomainfrom
inlined.cf3-terraform
Closed

Create a command to export Firebase Functions' IaC#10034
inlined wants to merge 4 commits intomainfrom
inlined.cf3-terraform

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Mar 6, 2026

Checkpointing a work in progress for an experimental feature to export Functions' IaC. This can be used to eventually support management via Terraform or the Application Design Center.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an experimental feature to export Firebase Cloud Functions' Infrastructure as Code (IaC). The primary goal is to provide a mechanism for managing functions through external tools like Terraform or Application Design Center by generating a manifest of the functions' configuration. This initial checkpoint focuses on establishing the command-line interface and the foundational logic for manifest generation, with support for different output formats planned for future iterations.

Highlights

  • New functions:export command: A new experimental command functions:export has been introduced, allowing users to export Firebase Cloud Functions' Infrastructure as Code (IaC). This command supports specifying an output format (currently only 'internal' is implemented) and an optional codebase.
  • Experimental Feature Flag: The functions:export command is gated behind a new experimental flag, functionsexport, indicating it is a work in progress and not yet publicly available.
  • Core Export Logic: A new utility function, getFunctionsManifest, was added to handle the core logic of discovering and building the functions manifest, leveraging existing runtime delegates and environment variable loading.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/commands/functions-export.ts
    • Added a new command definition for functions:export.
  • src/commands/index.ts
    • Conditionally registered the new functions:export command under the client.functions namespace, dependent on the functionsexport experiment flag.
  • src/deploy/functions/export.ts
    • Added the getFunctionsManifest function, which orchestrates the discovery and building of the functions manifest.
  • src/experiments.ts
    • Introduced a new experimental flag functionsexport to control the visibility and availability of the functions IaC export feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an experimental feature to export Firebase Functions' Infrastructure as Code (IaC). The changes include a new command functions:export, its integration into the CLI, and the underlying logic to generate the manifest. The implementation correctly handles different output formats and codebase selections. A minor improvement opportunity was identified regarding the use of console.log for user-facing output, which violates the established style guide.

Comment on lines +55 to +57
for (const [file, contents] of Object.entries(manifest)) {
console.log(`Manifest file: ${clc.bold(file)}`);
console.log(contents);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository's style guide (line 29) explicitly states to "Use the central logger (src/logger.ts); never use console.log() for user-facing output." Please replace console.log with logger.info or logger.debug as appropriate for user-facing output.

For example, logger.info(Manifest file: ${clc.bold(file)}); and logger.info(contents);

      logger.info(`Manifest file: ${clc.bold(file)}`);
      logger.info(contents);

@inlined
Copy link
Copy Markdown
Member Author

inlined commented Mar 17, 2026

My update changes so much that I might as well create a fresh review.

@inlined inlined closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants