Skip to content

Commit ac21a5f

Browse files
authored
Fix typo in RC Config Settings (#573)
1 parent 43be377 commit ac21a5f

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

docs/readme.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ Release Notes
7171
- Changes
7272
- General (Android): Update to Firebase Android BoM version 31.1.1.
7373
- General (iOS): Update to Firebase Cocoapods version 10.3.0.
74+
- Remote Config: Added `ConfigSettings.MinimumFetchIntervalInMilliseconds`,
75+
which should be used instead of `MinimumFetchInternalInMilliseconds`. The
76+
old one is considered deprecated, and will be removed with the next major release.
7477

7578
### 10.2.0
7679
- Changes

remote_config/src/ConfigSettings.cs

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,28 @@ public struct ConfigSettings {
3030
/// @note Fetches less than duration seconds after the last fetch from the
3131
/// Firebase Remote Config server would use values returned during the last
3232
/// fetch. Default is 12 hours.
33-
public ulong MinimumFetchInternalInMilliseconds { get; set; }
33+
public ulong MinimumFetchIntervalInMilliseconds { get; set; }
34+
35+
/// The minimum interval between successive fetch calls.
36+
///
37+
/// @deprecated Use MinimumFetchIntervalInMilliseconds instead. This will be
38+
/// removed in the next major release.
39+
public ulong MinimumFetchInternalInMilliseconds {
40+
get { return MinimumFetchIntervalInMilliseconds; }
41+
set { MinimumFetchIntervalInMilliseconds = value; }
42+
}
3443

3544
internal static ConfigSettings FromInternal(ConfigSettingsInternal csInternal) {
3645
return new ConfigSettings {
3746
FetchTimeoutInMilliseconds = csInternal.fetch_timeout_in_milliseconds,
38-
MinimumFetchInternalInMilliseconds = csInternal.minimum_fetch_interval_in_milliseconds
47+
MinimumFetchIntervalInMilliseconds = csInternal.minimum_fetch_interval_in_milliseconds
3948
};
4049
}
4150

4251
internal static ConfigSettingsInternal ToInternal(ConfigSettings cs) {
4352
ConfigSettingsInternal csInternal = new ConfigSettingsInternal();
4453
csInternal.fetch_timeout_in_milliseconds = cs.FetchTimeoutInMilliseconds;
45-
csInternal.minimum_fetch_interval_in_milliseconds = cs.MinimumFetchInternalInMilliseconds;
54+
csInternal.minimum_fetch_interval_in_milliseconds = cs.MinimumFetchIntervalInMilliseconds;
4655
return csInternal;
4756
}
4857
}

0 commit comments

Comments
 (0)