Skip to content

[Dynamic Links] Remove the Dynamic Links library #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ body:
- Authentication
- Crashlytics
- Database
- DynamicLinks
- Firebase AI Logic
- Firestore
- Functions
- In-App Messaging
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/general-question.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ body:
- Authentication
- Crashlytics
- Database
- DynamicLinks
- Firebase AI Logic
- Firestore
- Functions
- In-App Messaging
Expand All @@ -72,7 +72,7 @@ body:
- Authentication
- Crashlytics
- Database
- DynamicLinks
- Firebase AI Logic
- Firestore
- Functions
- In-App Messaging
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ body:
- Authentication
- Crashlytics
- Database
- DynamicLinks
- Firebase AI Logic
- Firestore
- Functions
- In-App Messaging
Expand All @@ -104,7 +104,7 @@ body:
- Authentication
- Crashlytics
- Database
- DynamicLinks
- Firebase AI Logic
- Firestore
- Functions
- In-App Messaging
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
unity_platform_name:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
unity_platform_name:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
unity_platform_name:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
unity_platform_name:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_starter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ on:
required: true
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
# Additional CMake flags to use
additional_cmake_flags:
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
echo "platform='Android,iOS,tvOS,Windows,macOS,Linux,Playmode'" >> $GITHUB_OUTPUT
echo "release_label=nightly-$(date "+%Y%m%d-%H%M%S")" >> $GITHUB_OUTPUT
echo "release_version=NoVersion" >> $GITHUB_OUTPUT
echo "apis='analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'" >> $GITHUB_OUTPUT
echo "apis='analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'" >> $GITHUB_OUTPUT
echo "unity_version=2021" >> $GITHUB_OUTPUT
echo "should_trigger_package=true" >> $GITHUB_OUTPUT
echo "firebase_cpp_sdk_version=" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
unity_platform_name:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_swig.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string
# Additional CMake flags to use
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
required: true
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
mobile_test_on:
description: 'Run mobile tests on real and/or virtual devices? (value: real, virtual. separated by commas)'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:
type: string
apis:
description: 'CSV of apis to build and test'
default: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
required: true
type: string

Expand All @@ -42,7 +42,7 @@ permissions: write-all
env:
# Use SHA256 for hashing files.
hashCommand: "sha256sum"
default_apis: 'analytics,app_check,auth,crashlytics,database,dynamic_links,firebaseai,firestore,functions,installations,messaging,remote_config,storage'
default_apis: 'analytics,app_check,auth,crashlytics,database,firebaseai,firestore,functions,installations,messaging,remote_config,storage'

jobs:
package_sdks:
Expand Down
14 changes: 0 additions & 14 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ option(FIREBASE_INCLUDE_CRASHLYTICS
option(FIREBASE_INCLUDE_DATABASE
"Include the Firebase Realtime Database library."
${FIREBASE_INCLUDE_LIBRARY_DEFAULT})
option(FIREBASE_INCLUDE_DYNAMIC_LINKS
"Include the Firebase Dynamic Links library."
${FIREBASE_INCLUDE_LIBRARY_DEFAULT})
option(FIREBASE_INCLUDE_INSTALLATIONS
"Include the Firebase Installations library."
${FIREBASE_INCLUDE_LIBRARY_DEFAULT})
Expand Down Expand Up @@ -268,11 +265,6 @@ if (DESKTOP AND APPLE AND FIREBASE_INCLUDE_EDITOR_TOOL AND NOT FIREBASE_GENERATE
add_subdirectory(editor)
endif()

if (PLATFORM STREQUAL TVOS OR PLATFORM STREQUAL SIMULATOR_TVOS)
# Dynamic Links is not supported on tvOS.
set(FIREBASE_INCLUDE_DYNAMIC_LINKS OFF)
endif()

if (FIREBASE_INCLUDE_ANALYTICS)
add_subdirectory(analytics)
list(APPEND TARGET_LINK_LIB_NAMES "firebase_analytics" "firebase_analytics_swig")
Expand Down Expand Up @@ -303,12 +295,6 @@ if (FIREBASE_INCLUDE_DATABASE)
list(APPEND DOCUMENTATION_ONLY_LIB_NAMES "firebase_database_swig")
list(APPEND PROJECT_LIST_HEADER " X(Database)")
endif()
if (FIREBASE_INCLUDE_DYNAMIC_LINKS)
add_subdirectory(dynamic_links)
list(APPEND TARGET_LINK_LIB_NAMES "firebase_dynamic_links" "firebase_dynamic_links_swig")
list(APPEND DOCUMENTATION_ONLY_LIB_NAMES "firebase_dynamic_links_swig")
list(APPEND PROJECT_LIST_HEADER " X(DynamicLinks)")
endif()
if (FIREBASE_INCLUDE_INSTALLATIONS)
add_subdirectory(installations)
list(APPEND TARGET_LINK_LIB_NAMES "firebase_installations" "firebase_installations_swig")
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ The repository contains the Firebase Unity SDK source, with support for Android,
iOS, and desktop platforms. Note that desktop is ***only supported for development
purposes***. It includes the following Firebase libraries:

- [Firebase AI Logic](https://firebase.google.com/docs/ai-logic/)
- [Google Analytics for Firebase](https://firebase.google.com/docs/analytics/)
- [Firebase App Check](https://firebase.google.com/docs/app-check/)
- [Firebase Authentication](https://firebase.google.com/docs/auth/)
- [Firebase Crashlytics](https://firebase.google.com/docs/crashlytics)
- [Firebase Realtime Database](https://firebase.google.com/docs/database/)
- [Firebase Dynamic Links](https://firebase.google.com/docs/dynamic-links/)
- [Cloud Firestore](https://firebase.google.com/docs/firestore/)
- [Cloud Functions for Firebase](https://firebase.google.com/docs/functions/)
- [Firebase Invites](https://firebase.google.com/docs/invites/)
- [Firebase Cloud Messaging](https://firebase.google.com/docs/cloud-messaging/)
- [Firebase Remote Config](https://firebase.google.com/docs/remote-config/)
- [Cloud Storage for Firebase](https://firebase.google.com/docs/storage/)
Expand Down Expand Up @@ -86,7 +85,7 @@ Expected output artifact is
python scripts/build_scripts/build_zips.py --platform=<target platform> --targets=<lib1> --targets=<lib2>
```

> **Note:** Supported library names: analytics, app_check, auth, crashlytics, database, dynamic_links, firebaseai, firestore, functions, installations, messaging, remote_config, storage
> **Note:** Supported library names: analytics, app_check, auth, crashlytics, database, firebaseai, firestore, functions, installations, messaging, remote_config, storage

## Packaging

Expand Down
2 changes: 0 additions & 2 deletions app/platform/Unity/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@
[assembly: InternalsVisibleTo("Firebase.Auth")]
[assembly: InternalsVisibleTo("Firebase.Crashlytics")]
[assembly: InternalsVisibleTo("Firebase.Database")]
[assembly: InternalsVisibleTo("Firebase.DynamicLinks")]
[assembly: InternalsVisibleTo("Firebase.Firestore")]
[assembly: InternalsVisibleTo("Firebase.Functions")]
[assembly: InternalsVisibleTo("Firebase.Installations")]
[assembly: InternalsVisibleTo("Firebase.InstanceId")]
[assembly: InternalsVisibleTo("Firebase.Invites")]
[assembly: InternalsVisibleTo("Firebase.Messaging")]
[assembly: InternalsVisibleTo("Firebase.RemoteConfig")]
[assembly: InternalsVisibleTo("Firebase.Storage")]
Expand Down
8 changes: 0 additions & 8 deletions app/src/swig/app.i
Original file line number Diff line number Diff line change
Expand Up @@ -688,10 +688,6 @@ static firebase::AppOptions* AppOptionsLoadFromJsonConfig(const char* config) {
"Firebase.Database.FirebaseDatabase, Firebase.Database",
"database"
),
new EnableModuleParams(
"Firebase.DynamicLinks.DynamicLinks, Firebase.DynamicLinks",
"dynamic_links"
),
new EnableModuleParams(
"Firebase.Functions.FirebaseFunctions, Firebase.Functions",
"functions"
Expand All @@ -700,10 +696,6 @@ static firebase::AppOptions* AppOptionsLoadFromJsonConfig(const char* config) {
"Firebase.Installations.FirebaseInstallations, Firebase.Installations",
"installations"
),
new EnableModuleParams(
"Firebase.Invites.FirebaseInvites, Firebase.Invites",
"invites"
),
new EnableModuleParams(
"Firebase.Messaging.FirebaseMessaging, Firebase.Messaging",
"messaging"
Expand Down
3 changes: 0 additions & 3 deletions app/src/unity_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,9 @@ jint JNI_OnLoad(JavaVM *jvm, void *reserved) {
{"com/google/firebase/auth/FirebaseAuth", "auth"},
{"com/google/firebase/crashlytics/FirebaseCrashlytics", "crashlytics"},
{"com/google/firebase/database/FirebaseDatabase", "database"},
{"com/google/firebase/dynamiclinks/FirebaseDynamicLinks",
"dynamic_links"},
{"com/google/firebase/functions/FirebaseFunctions", "functions"},
{"com/google/firebase/installations/FirebaseInstallations",
"installations"},
{"com/google/android/gms/appinvite/AppInvite", "invites"},
{"com/google/firebase/messaging/FirebaseMessaging", "messaging"},
{"com/google/firebase/perf/FirebasePerformance", "performance"},
{"com/google/firebase/remoteconfig/FirebaseRemoteConfigInfo",
Expand Down
4 changes: 2 additions & 2 deletions auth/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -887,14 +887,14 @@ PlayerSettings:
apiCompatibilityLevelPerPlatform: {}
m_RenderingPath: 1
m_MobileRenderingPath: 1
metroPackageName: InvitesUnityTestApp
metroPackageName: AuthUnityTestApp
metroPackageVersion:
metroCertificatePath:
metroCertificatePassword:
metroCertificateSubject:
metroCertificateIssuer:
metroCertificateNotAfter: 0000000000000000
metroApplicationDescription: InvitesUnityTestApp
metroApplicationDescription: AuthUnityTestApp
wsaImages: {}
metroTileShortName:
metroTileShowName: 0
Expand Down
5 changes: 0 additions & 5 deletions cmake/android_dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ set(FIREBASE_DATABASE_ANDROID_DEPS
"com.google.android.gms:play-services-base:18.6.0"
)

set(FIREBASE_DYNAMIC_LINKS_ANDROID_DEPS
"com.google.firebase:firebase-dynamic-links:22.1.0"
"com.google.firebase:firebase-analytics:22.4.0"
)

set(FIREBASE_FIRESTORE_ANDROID_DEPS
"com.google.firebase:firebase-firestore:25.1.3"
"com.google.firebase:firebase-analytics:22.4.0"
Expand Down
4 changes: 2 additions & 2 deletions database/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -924,14 +924,14 @@ PlayerSettings:
apiCompatibilityLevelPerPlatform: {}
m_RenderingPath: 1
m_MobileRenderingPath: 1
metroPackageName: InvitesUnityTestApp
metroPackageName: DatabaseUnityTestApp
metroPackageVersion:
metroCertificatePath:
metroCertificatePassword:
metroCertificateSubject:
metroCertificateIssuer:
metroCertificateNotAfter: 0000000000000000
metroApplicationDescription: InvitesUnityTestApp
metroApplicationDescription: DatabaseUnityTestApp
wsaImages: {}
metroTileShortName:
metroTileShowName: 0
Expand Down
46 changes: 0 additions & 46 deletions docs/dynamic_links/DynamicLinksReadme.md

This file was deleted.

Binary file removed docs/dynamic_links/DynamicLinks_icon.png
Binary file not shown.
Binary file removed docs/dynamic_links/DynamicLinks_large.png
Binary file not shown.
Binary file removed docs/dynamic_links/DynamicLinks_small.png
Binary file not shown.
8 changes: 5 additions & 3 deletions docs/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@ Firebase Unity SDK
The Firebase Unity SDK provides Unity packages for the following Firebase
features on *iOS*, *tvOS* and *Android*.

Note: Firebase Dynamic Links is not supported on tvOS.

| Feature | Unity Package |
|:-----------------------------------:|:---------------------------------:|
| Firebase AI Logic | FirebaseAI.unitypackage |
| Firebase Analytics | FirebaseAnalytics.unitypackage |
| Firebase App Check | FirebaseAppCheck.unitypackage |
| Firebase Authentication | FirebaseAuth.unitypackage |
| Firebase Crashlytics | FirebaseCrashlytics.unitypackage |
| Firebase Dynamic Links (deprecated) | FirebaseDynamicLinks.unitypackage |
| Cloud Firestore | FirebaseFirestore.unitypackage |
| Firebase Functions | FirebaseFunctions.unitypackage |
| Firebase Installations | FirebaseInstallations.unitypackage|
Expand All @@ -31,6 +29,7 @@ desktop builds on Windows, OS X, and Linux:

| Feature | Unity Package |
|:----------------------------------:|:---------------------------------:|
| Firebase AI Logic | FirebaseAI.unitypackage |
| Firebase Authentication | FirebaseAuth.unitypackage |
| Firebase App Check | FirebaseAppCheck.unitypackage |
| Firebase Realtime Database* | FirebaseDatabase.unitypackage |
Expand Down Expand Up @@ -115,6 +114,9 @@ Release Notes
- Analytics: Removed deprecated `FirebaseAnalytics.ParameterGroupId`
and `Parameter.Dispose` methods.
- Auth: Removed deprecated `FirebaseUser.UpdateEmailAsync`.
- Dynamic Links: Removed the Dynamic Links SDK. See the [support
documentation](https://firebase.google.com/support/dynamic-links-faq)
for more information.
- Messaging: Removed deprecated `FirebaseMessage.Dispose`,
`FirebaseNotification.Dispose`, and `MessagingOptions.Dispose` methods.

Expand Down
Loading
Loading