Make volume package usable from non-Firecracker runtimes #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
volume-runc
branch
2 times, most recently
from
334dc1a to
6794724
Compare
It isn't fully transparent though. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
austinvazquez
approved these changes
May 19, 2022
Kern--
approved these changes
May 19, 2022
There was a problem hiding this comment.
I think this is fine for now, but I'd like to see a follow up (maybe just an issue for now) with a deeper dive on if we could make this more transparent. Could we do it with the abstractions we have today? Is there a way to extend the containerd abstractions to allow this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't fully transparent though.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.