Update dev-machine-setup.md #5269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arikanev, Could you please fix your commit to pass DCO? You need to add a commit body and commit with |
roypat
added
the
Status: Awaiting author
|
Hey @arikanev, thanks for the contribution! We're reviewing stale PRs, and noticed this one has been stuck for a while. Are you planning to bring it to the finish line? |
Added step in readme on enabling autodetect for bridged networking on VMWare. Suggested-by: Ariel Kanevsky <arikanevsky@gmail.com> Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
force-pushed
the
add-VMware-readme-info
branch
from
949662d to
d030f88
Compare
|
I've amended the commit and resubmit it so that we can finally merge this documentation fix. |
Manciukic
added
Status: Awaiting review
ShadowCurse
approved these changes
Aug 6, 2025
roypat
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added step in readme on enabling autodetect for bridged networking on VMWare.
...
Reason
Necessary for VMware networking functionality to work correctly.
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.