test(balloon): ensure we always wait long enough for stats to update #5325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always wait twice the stats polling interval when trying to a comparison
between "old" and "new" balloon stats. This is to ensure that the "new"
stats are definitely new, and we didn't hit some unlikely race condition
where we request stats right as the device is still in the process of
updating them.
We were seeing intermittent issues such as
test_balloon.py:531: in test_balloon_snapshot
assert stats_after_snap["available_memory"]
> latest_stats["available_memory"]
E assert 186281984 > 186281984
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
==========================================
+ Coverage 82.98% 83.03% +0.05%
==========================================
Files 250 250
Lines 26828 26828
==========================================
+ Hits 22262 22276 +14
+ Misses 4566 4552 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
added
the
Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always wait twice the stats polling interval when trying to a comparison between "old" and "new" balloon stats. This is to ensure that the "new" stats are definitely new, and we didn't hit some unlikely race condition where we request stats right as the device is still in the process of updating them.
We were seeing intermittent issues such as
test_balloon.py:531: in test_balloon_snapshot
assert stats_after_snap["available_memory"]
> latest_stats["available_memory"]
E assert 186281984 > 186281984
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.