chore: remove vmclock patches#5826
Merged
JamesC1305 merged 6 commits intofirecracker-microvm:mainfrom Apr 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5826 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 276 276
Lines 29546 29546
=======================================
Hits 24546 24546
Misses 5000 5000
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesC1305
added
the
Status: Awaiting review
JackThomson2
previously approved these changes
Apr 9, 2026
JamesC1305
force-pushed
the
remove-vmclock-patches
branch
2 times, most recently
from
679f332 to
85b7d63
Compare
With the release of microvm-kernel-5.10.252-285.992.amzn2 and microvm-kernel-6.1.167-27.319.amzn2023, the vmclock patches are now present in the kernel, meaning the copies we apply on kernel build can be safely removed. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
JamesC1305
force-pushed
the
remove-vmclock-patches
branch
from
85b7d63 to
c1cdb8d
Compare
JamesC1305
requested review from
Manciukic,
kalyazin and
micz010
as code owners
JamesC1305
force-pushed
the
remove-vmclock-patches
branch
from
c1cdb8d to
ec6aeff
Compare
Update the Kconfig files to be those of the 6.1.167 and 5.10.252 microvm kernel releases. As part of this, Drop Kconfig patches for PCI, vmclock, virtio-mem and virtio-pmem, since the latest microvm kernel config already enables the required options. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Update snapshot docs to reflect the fact that vmclock is now available in newly built microvm kernels. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
JamesC1305
force-pushed
the
remove-vmclock-patches
branch
from
ec6aeff to
2e8b529
Compare
zulinx86
approved these changes
Apr 15, 2026
JackThomson2
approved these changes
Apr 15, 2026
Manciukic
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rebuild.shscript slightly to prevent errors on non-existent patchesReason
Patches no longer needed due to AL kernel backports
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.