flameco,types: Fix invariant check for BitVectors

Author: jumpsiegel

src/flamenco/runtime/sysvar/fd_sysvar_slot_history.c

@@ -71,6 +71,7 @@ fd_sysvar_slot_history_init( fd_exec_slot_ctx_t * slot_ctx, fd_spad_t * runtime_
   history->bits_bitvec_offset = (ulong)((uchar*)blocks - (uchar*)history);
   history->bits_len           = slot_history_max_entries;
   history->bits_bitvec_len    = blocks_len;
+  history->has_bits           = 1;
   memset( blocks, 0, sizeof(ulong) * blocks_len );
 
   /* TODO: handle slot != 0 init case */

src/flamenco/types/fd_types.c

@@ -9015,7 +9015,7 @@ static int fd_slot_history_decode_footprint_inner( fd_bincode_decode_ctx_t * ctx
     ulong len;
     err = fd_bincode_uint64_decode( &len, ctx );
     if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
-    if( o && len > inner_len * sizeof(ulong) * 8UL ) return FD_BINCODE_ERR_ENCODING;
+    if( len > inner_len * sizeof(ulong) * 8UL ) return FD_BINCODE_ERR_ENCODING;
   }
   err = fd_bincode_uint64_decode_footprint( ctx );
   if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
@@ -19476,7 +19476,7 @@ static int fd_gossip_slots_decode_footprint_inner( fd_bincode_decode_ctx_t * ctx
     ulong len;
     err = fd_bincode_uint64_decode( &len, ctx );
     if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
-    if( o && len > inner_len * sizeof(uchar) * 8UL ) return FD_BINCODE_ERR_ENCODING;
+    if( len > inner_len * sizeof(uchar) * 8UL ) return FD_BINCODE_ERR_ENCODING;
   }
   return 0;
 }
@@ -20270,9 +20270,6 @@ int fd_gossip_duplicate_shred_encode( fd_gossip_duplicate_shred_t const * self,
 static int fd_gossip_duplicate_shred_decode_footprint_inner( fd_bincode_decode_ctx_t * ctx, ulong * total_sz ) {
   if( ctx->data>=ctx->dataend ) { return FD_BINCODE_ERR_OVERFLOW; };
   int err = 0;
-  err = fd_gossip_duplicate_shred_validator( ctx );
-  if( FD_UNLIKELY( err != FD_BINCODE_SUCCESS ) )
-    return err;
   err = fd_bincode_uint16_decode_footprint( ctx );
   if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
   err = fd_pubkey_decode_footprint_inner( ctx, total_sz );
@@ -20909,7 +20906,7 @@ static int fd_restart_raw_offsets_decode_footprint_inner( fd_bincode_decode_ctx_
     ulong len;
     err = fd_bincode_uint64_decode( &len, ctx );
     if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
-    if( o && len > inner_len * sizeof(uchar) * 8UL ) return FD_BINCODE_ERR_ENCODING;
+    if( len > inner_len * sizeof(uchar) * 8UL ) return FD_BINCODE_ERR_ENCODING;
   }
   return 0;
 }
@@ -21829,7 +21826,7 @@ static int fd_crds_bloom_decode_footprint_inner( fd_bincode_decode_ctx_t * ctx,
     ulong len;
     err = fd_bincode_uint64_decode( &len, ctx );
     if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;
-    if( o && len > inner_len * sizeof(ulong) * 8UL ) return FD_BINCODE_ERR_ENCODING;
+    if( len > inner_len * sizeof(ulong) * 8UL ) return FD_BINCODE_ERR_ENCODING;
   }
   err = fd_bincode_uint64_decode_footprint( ctx );
   if( FD_UNLIKELY( err!=FD_BINCODE_SUCCESS ) ) return err;

src/flamenco/types/fd_types.h

@@ -3041,6 +3041,7 @@ struct fd_gossip_node_instance {
 typedef struct fd_gossip_node_instance fd_gossip_node_instance_t;
 #define FD_GOSSIP_NODE_INSTANCE_ALIGN alignof(fd_gossip_node_instance_t)
 
+/* https://github.com/firedancer-io/agave/blob/540d5bc56cd44e3cc61b179bd52e9a782a2c99e4/gossip/src/duplicate_shred.rs#L25 */
 /* Encoded Size: Dynamic */
 struct fd_gossip_duplicate_shred {
   ushort duplicate_shred_index;
@@ -3077,6 +3078,7 @@ struct fd_gossip_socket_entry {
 typedef struct fd_gossip_socket_entry fd_gossip_socket_entry_t;
 #define FD_GOSSIP_SOCKET_ENTRY_ALIGN alignof(fd_gossip_socket_entry_t)
 
+/* https://github.com/firedancer-io/agave/blob/540d5bc56cd44e3cc61b179bd52e9a782a2c99e4/gossip/src/contact_info.rs#L85 */
 /* Encoded Size: Dynamic */
 struct fd_gossip_contact_info_v2 {
   fd_pubkey_t from;

src/flamenco/types/fd_types.json

@@ -2047,7 +2047,6 @@
     {
       "name": "gossip_duplicate_shred",
       "type": "struct",
-      "validator": "fd_gossip_duplicate_shred_validator",
       "fields": [
         { "name": "duplicate_shred_index", "type": "ushort" },
         { "name": "from", "type": "pubkey" },

src/flamenco/types/fd_types_custom.c

@@ -293,18 +293,6 @@ fd_rust_duration_footprint_validator ( fd_bincode_decode_ctx_t * ctx ) {
   return FD_BINCODE_SUCCESS;
 }
 
-int
-fd_gossip_duplicate_shred_validator ( fd_bincode_decode_ctx_t * ctx ) {
-#if 1
-  (void) ctx;
-#else
-  fd_gossip_duplicate_shred_t *d = (fd_gossip_duplicate_shred_t *) ctx->data;
-  if( FD_UNLIKELY( (d->_unused_shred_type != 0x5a) || (d->_unused_shred_type != 0xa5) ) )
-    return FD_BINCODE_ERR_ENCODING;
-#endif
-  return FD_BINCODE_SUCCESS;
-}
-
 void fd_vote_accounts_decode_inner( void * struct_mem, void * * alloc_mem, fd_bincode_decode_ctx_t * ctx ) {
   fd_vote_accounts_t * self = (fd_vote_accounts_t *)struct_mem;
   ulong vote_accounts_len;

src/flamenco/types/fd_types_custom.h

@@ -197,9 +197,6 @@ fd_rust_duration_normalize ( fd_rust_duration_t * );
 int
 fd_rust_duration_footprint_validator ( fd_bincode_decode_ctx_t * ctx );
 
-int
-fd_gossip_duplicate_shred_validator ( fd_bincode_decode_ctx_t * ctx );
-
 void fd_vote_accounts_decode_inner( void * struct_mem, void * * alloc_mem, fd_bincode_decode_ctx_t * ctx );
 void fd_vote_accounts_decode_inner_global( void * struct_mem, void * * alloc_mem, fd_bincode_decode_ctx_t * ctx );