Skip to content

Wrong version number in log file #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ripatel-fd opened this issue Apr 3, 2025 · 1 comment
Open

Wrong version number in log file #4705

ripatel-fd opened this issue Apr 3, 2025 · 1 comment

Comments

@ripatel-fd
Copy link
Contributor

The default log file path starts with /tmp/fd-0.0.0-

I guess we never noticed, but the 0.0.0 refers to a version number declared in fd_util_base.h.
Should be removed and replaced with fdctl's version.h.
@aannnguyen aannnguyen mentioned this issue Apr 15, 2025
Closed
@aannnguyen
Copy link

aannnguyen commented Apr 16, 2025 •
edited
Loading

@ripatel-fd can you please take a look at my PR, I think it'll resolve this issue.

@aannnguyen aannnguyen mentioned this issue Apr 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: update fd_log.c filename behavior aannnguyen/firedancer
2 participants
@ripatel-fd @aannnguyen