Fix: update fd_log.c to improve logging behavior #4820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensured consistency with other logging components
|
@ripatel-fd Please help me review this, thanks |
|
Hello @aannnguyen, thank you for the contribution. Unfortunately the fix isn't quite as simple. fd_log is part of the base utilities, so the lowest layer of the dependency tree. fdctl is the root of the dependency tree. Having the base utils depend on the root would be a circular dependency and probably cause failures. I'm going to close this for now as we plan to fix this soon. |
|
Hi @ripatel-fd, thanks for your reply. I just wondering if there is any other issue that need help at the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Wrong version number in log file #4705