Skip to content

agave: update to 2.2.12 #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

agave: update to 2.2.12 #4884

merged 1 commit into from
Apr 28, 2025

Conversation

ptaffet-jump
Copy link
Contributor

@ptaffet-jump ptaffet-jump commented Apr 25, 2025 •
edited
Loading

I basically hit the same minor issues as Anway:

Rebase to v2.2.7 was mostly clean, it needed a slight modification to the verify precompiles commit.

@ptaffet-jump ptaffet-jump mentioned this pull request Apr 25, 2025
Closed
anwayde
anwayde approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@anwayde anwayde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did notice though that we use solana_sdk::feature_set in firedancer_poh_recorder.rs whereas most of the agave codebase uses agave_feature_set - not introduced in this PR but just wanted to note in case we should also use the latter.

@ptaffet-jump ptaffet-jump added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 0020058 Apr 28, 2025
10 checks passed
@ptaffet-jump ptaffet-jump deleted the ptaffet/agave-20212 branch April 28, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anwayde anwayde anwayde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptaffet-jump @anwayde