Snapshot Loader 2.0 #4885
Draft
Snapshot Loader 2.0 #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
force-pushed
the
ripatel/snapshot-tiles
branch
from
fd600ba to
10a9577
Compare
mmcgee-jump
reviewed
Apr 28, 2025
| fd_filerd_tile_t * ctx = fd_topo_obj_laddr( topo, tile->tile_obj_id ); | ||
| fd_memset( ctx, 0, sizeof(fd_filerd_tile_t) ); | ||
|
|
||
| if( FD_UNLIKELY( tile->in_cnt !=0UL ) ) FD_LOG_ERR(( "tile `" NAME "` has %lu ins, expected 0", tile->in_cnt )); |
There was a problem hiding this comment.
These belong in unprivileged_init. privileged_init is only for the minimally scoped, auditable set of stuff that must happen unsandboxed
mmcgee-jump
reviewed
Apr 28, 2025
| if( FD_UNLIKELY( tile->out_cnt!=1UL ) ) FD_LOG_ERR(( "tile `" NAME "` has %lu outs, expected 1", tile->out_cnt )); | ||
|
|
||
| ctx->fd = open( tile->filerd.file_path, O_RDONLY|O_CLOEXEC ); | ||
| if( FD_UNLIKELY( ctx->fd<0 ) ) FD_LOG_ERR(( "open() failed (%i-%s)", errno, fd_io_strerror( errno ) )); |
There was a problem hiding this comment.
This is going to be a very frequently hit operator facing error. Please add a long error message describing the problem when errno is ENOENT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.